Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Upgrade to cypress 10 #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alex-wilmer
Copy link

@alex-wilmer alex-wilmer commented Oct 17, 2022

I needed to test this against Cypress 10--I couldn't get it to work on my project so I forked this and upgraded here and it DOES work which is great.

Opening this PR to start a conversation about which version the recipes here should be running against. If this is moving in the right direction I can update the rest of the recipes.

Let me know thanks

Checklist:

  • No linting issues
  • Commits are compliant with commitizen
  • CI tests have passed
  • Documentation updated

Summary of changes

  • Upgrade to Cypress 10 (only in react-html-input recipe)
  • Run automatic migrations

@abramenal
Copy link
Owner

As of this change, I feel further maintenance of this package is not needed: https://www.cypress.io/blog/2022/01/19/uploading-files-with-selectfile/

@alex-wilmer or are there scenarios where you would still rely on cypress-file-upload instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants