Add optional encoding
argument to set output character encoding
#47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds an optional
encoding
argument to#text
,#html
and.read
for setting the output character encoding, which is passed to Tika as the--encoding
option. This value is validated against Ruby'sEncoding.name_list
, raising anArgumentError
if it isn't included in the list.Why is it needed?
So we can set the output encoding via Henkei / Tika instead of having to do it ourselves afterwards.
Where should the reviewer start?
lib/henkei.rb:222
How should this be manually tested?