Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open readme in browser #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions app/res/menu/file_view.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
<?xml version="1.0" encoding="utf-8"?><!--
Copyright 2012 GitHub Inc.

Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -15,22 +14,26 @@
limitations under the License.
-->
<menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" >
xmlns:app="http://schemas.android.com/apk/res-auto">

<item
android:id="@+id/m_wrap"
app:showAsAction="never"
android:title="@string/enable_wrapping"/>
<item
android:id="@+id/m_render_markdown"
android:enabled="false"
app:showAsAction="never"
android:title="@string/render_markdown"
android:visible="false"/>
<item
android:id="@+id/m_share"
android:icon="@drawable/abc_ic_menu_share_mtrl_alpha"
app:showAsAction="never"
android:title="@string/share"/>
<item
android:id="@+id/m_wrap"
android:title="@string/enable_wrapping"
app:showAsAction="never" />
<item
android:id="@+id/m_render_markdown"
android:enabled="false"
android:title="@string/render_markdown"
android:visible="false"
app:showAsAction="never" />
<item
android:id="@+id/m_share"
android:icon="@drawable/abc_ic_menu_share_mtrl_alpha"
android:title="@string/share"
app:showAsAction="never" />
<item
android:id="@+id/m_open_in_browser"
android:title="@string/open_in_browser"
app:showAsAction="never" />

</menu>
1 change: 1 addition & 0 deletions app/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@
<string name="render_markdown">Render markdown</string>
<string name="copy_hash">Copy hash</string>
<string name="toast_msg_copied">Copied to clipboard</string>
<string name="open_in_browser">Open in Browser</string>

<!-- Navigation drawer strings -->
<string name="navigation_drawer_open">Open navigation drawer</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import com.github.mobile.util.AvatarLoader;
import com.github.mobile.util.HttpImageGetter;
import com.github.mobile.util.MarkdownUtils;
import com.github.mobile.util.OpenBrowserUtils;
import com.github.mobile.util.PreferenceUtils;
import com.github.mobile.util.ShareUtils;
import com.github.mobile.util.SourceEditor;
Expand Down Expand Up @@ -190,6 +191,10 @@ public boolean onOptionsItemSelected(MenuItem item) {
shareFile();
return true;

case R.id.m_open_in_browser:
openBrowser();
return true;

case R.id.m_render_markdown:
if (editor.isMarkdown()) {
item.setTitle(R.string.render_markdown);
Expand Down Expand Up @@ -247,6 +252,11 @@ private void shareFile() {
"https://github.com/" + id + "/blob/" + branch + '/' + path));
}

private void openBrowser() {
String id = repo.generateId();
startActivity(OpenBrowserUtils.create("https://github.com/" + id + "/blob/" + branch + '/' + path));
}

private void loadMarkdown() {
ViewUtils.setGone(loadingBar, false);
ViewUtils.setGone(codeView, true);
Expand Down
34 changes: 34 additions & 0 deletions app/src/main/java/com/github/mobile/util/OpenBrowserUtils.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
package com.github.mobile.util;

import android.content.Intent;
import android.net.Uri;

/**
* Created by jaellysbales on 6/19/15.
* Utilities for opening file in browser.
*/
public class OpenBrowserUtils {

/**
* Create intent with file URL
*
* @param url
* @return intent
*/
public static Intent create(final String url) {
String fileUrl = url;
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse(url));
return intent;
}

/**
* Get URL from intent
*
* @param intent
* @return url
*/
public static String getBody(final Intent intent) {
return intent != null ? intent.getStringExtra(Intent.ACTION_VIEW) : null;
}
}