Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Work pull request. #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
import org.eclipse.egit.github.core.Authorization;
import org.eclipse.egit.github.core.service.OAuthService;


public class AccountAuthenticator extends AbstractAccountAuthenticator {

private static final String TAG = "GHAccountAuthenticator";
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/com/github/mobile/core/gist/FullGist.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
import org.eclipse.egit.github.core.Comment;
import org.eclipse.egit.github.core.Gist;



/**
* Gist model with comments and starred status
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@
*/
public class AccountDataManager {



private static final String TAG = "AccountDataManager";

private static final Executor EXECUTOR = Executors.newFixedThreadPool(10);
Expand Down Expand Up @@ -194,6 +196,8 @@ public Collection<IssueFilter> getIssueFilters() {
return Collections.emptyList();
}



/**
* Get bookmarked issue filters
*
Expand Down Expand Up @@ -304,4 +308,11 @@ protected void onException(Exception e) throws RuntimeException {
}
}.execute();
}

/**
* I'm assuming this class would be a good place to put in the code
* that would also make the request to get and set the information for the user's profile
* settings.
**/

}
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,10 @@ public CharSequence getPageTitle(int position) {
return null;
}
}

/**
* In this class we would also tell he pager adapter to request
* the return of the 'settings' option.
* We might need to also create a fragment for the info.
*/
}