Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit1 week4 hw #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

unit1 week4 hw #19

wants to merge 2 commits into from

Conversation

vhart
Copy link

@vhart vhart commented Aug 15, 2015

No description provided.

@Mataniko
Copy link

Hey Varindra,

Great job on the homework!

A couple of things to improve:

  • Make sure you follow the requirements - those details seem pretty minor when you work on a small assignment, but are important when working as part of a team. A few examples:
    • CQCategory is named Option
    • The OSTableViewController has a Save button that doesn't do much and is not required.
  • Your data is defined in the OSTableViewController implementation, try to separate your Model from your View/Controller. In this case, a separate class containing the data would be the right way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vhart @Mataniko