chore(deps): cleaned up irrelevant dependencies in ui-markdown-editor #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mttrbrts
changed the title
|
@irmerk @mttrbrts Any updates? |
shivaylamba
approved these changes
Mar 15, 2021
jolanglinais
suggested changes
Mar 16, 2021
|
@irmerk I have rebase the commits. Any updates regarding this PR? |
|
Looking at this now @Cronus1007 , apologies for the delay. Can you rebase to resolve conflicts in |
jolanglinais
added
Package: Markdown Editor ⌨️
Type: Dependencies 🏠
|
@irmerk I have resolved merge conflicts. |
jolanglinais
reviewed
Apr 6, 2021
| --- | ||
| The functions in `clauseProps` like `CLAUSE_DELETE_FUNCTION`,`CLAUSE_EDIT_FUNCTION` and `CLAUSE_TEST_FUNCTION` are not implemented by default because they typically require interaction with other components or the persistence layer of the embedding application. | ||
| These functions will be supplied by the user of the component. | ||
| For more information in realtion to the `props` , `values` and `functionality` of Contract Editor visit [README.md](./src/ContractEditor/README.md) |
There was a problem hiding this comment.
One last change, I think we should remove this last line since that README file no longer exists.
There was a problem hiding this comment.
Also keep the --- horizontal rule just after this section you added.
|
Still unsure about the huge addition to |
Cronus1007
force-pushed
the
issue-
branch
2 times, most recently
from
318fb19
to
e3831cf
Compare
Signed-off-by: Cronus1007 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.masterfromfork:branchname