-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[discuss] code authentication service #776
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
========================================
Coverage ? 95.2%
========================================
Files ? 85
Lines ? 1835
Branches ? 356
========================================
Hits ? 1747
Misses ? 80
Partials ? 8
Continue to review full report at Codecov.
|
@@ -0,0 +1,50 @@ | |||
import { Twilio } from 'twilio'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it's safe to say that twilio pretty much dominates this field, I wonder if we should allow the user to supply some SMSService rather then depending on twilio.
Another option is to just call this package code-provider-twilio so that it will serve as an example for others that need different SMS providers. Once we get another feature request about some other provider we could refactor for generic SMS providers.
@pradel thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renaming it to twilio
will prevent another layer of abstraction that we might not need.. so i'm +1 for doing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notifme is a pretty good abstraction, and their notification catcher is really cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow didn't know about notifme.. it looks great! What do you think @ozsay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be useful, though I can't see all the features that twilio
provides (like messagingServiceSid
)
@ozsay From my understanding of the pr, this service can't be used alone since it does not take care of the user account creation right? |
@pradel true. we use it with another service. |
I guess this should be clarified somewhere in the documentation as we want the service to be able to register a user I think. |
bdf442b
to
3e57ec8
Compare
Hi,
I implemented a new authentication service which validates a previously sent code to the client.
Common use-cases:
The service both sends the code ("prepare authentication") using a code-provider and validates it after the client logs-in.
TODO:
@davidyaha Thoughts?