Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools - Cleanup #10444

Merged
merged 3 commits into from
Feb 17, 2025
Merged

Tools - Cleanup #10444

merged 3 commits into from
Feb 17, 2025

Conversation

BrettMayson
Copy link
Member

When merged this pull request will:

  • Removes outdated tools
  • Removes tools replaced by HEMTT equivalents

Some of the python I am not exactly sure what they do, if we need them, if they still work, etc.

If there are any that are useful they would be good to port to HEMTT instead of a python script here

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432
Copy link
Contributor

johnb432 commented Oct 21, 2024

I think stringtableduplicates.py's functionality is included in stringtable_validator.py fyi.


I know that extract_dependencies.py is still used for the website.

@BrettMayson
Copy link
Member Author

I'll let @PabstMirror weigh in if any more of these can be removed

@PabstMirror
Copy link
Contributor

can probably drop search_privates.py and search_unused_privates.py

@PabstMirror PabstMirror added area/tools ignore-changelog Release Notes: Excluded labels Nov 21, 2024
@BrettMayson BrettMayson marked this pull request as ready for review February 16, 2025 09:00
@BrettMayson
Copy link
Member Author

There are probably more things that can be removed but I don't want this to just sit as a draft forever

@PabstMirror PabstMirror merged commit cc3b2fa into acemod:master Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tools ignore-changelog Release Notes: Excluded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants