Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 15# #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for 15# #33

wants to merge 2 commits into from

Conversation

Serverfrog
Copy link

Added changes from #15 (comment)

@spannerman79
Copy link
Contributor

No - this will need ot be put into a difference branch and then later master changed accordingly.

There are those that still play 1.7.10 - and it would be ignorant and arrogant to assume otherwise.

@Serverfrog
Copy link
Author

@spannerman79 sorry i didn't know that this little change (a forced to string was never a problem in my world) breaks compatibility with older versions.
But without it`s breaking the current versions!
Beside that, nothing like this is ever mentioned in the Issue, so please add this if that this change is breaking the compatibility with 1.7.10.

If there are codebases for different Versions then they should be a detection of Versions and correct choosing of the correct codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants