-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: run
actionlint
for GitHub Actions variant (#518)
While rebasing #466 after #516 was landed I learned that I had actually mucked up my erb for the GitHub Actions workflow - this was only picked up because it was invalid YAML so Prettier errored. To help avoid mistakes in future, this introduces running [`actionlint`](https://github.com/rhysd/actionlint) as part of our _template_ CI. Since doing so means that `bin/ci-run` now includes a tool that isn't in our CI workflow, this PR can also be seen as the initial nudge towards a possible future with a very different approach to `bin/ci-run` (including not having it at all) that I've been wanting to bring up for discussion for a bit.
- Loading branch information
Showing
2 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,13 @@ | ||
template "variants/github_actions_ci/workflows/ci.yml.tt", ".github/workflows/ci.yml" | ||
copy_file "variants/github_actions_ci/workflows/deploy_to_ec2.yml", ".github/workflows/deploy_to_ec2.yml" | ||
copy_file "variants/github_actions_ci/workflows/deploy_to_heroku.yml", ".github/workflows/deploy_to_heroku.yml" | ||
|
||
append_to_file "bin/ci-run" do | ||
<<~ACTIONLINT | ||
echo "* ******************************************************" | ||
echo "* Running ActionLint" | ||
echo "* ******************************************************" | ||
actionlint | ||
ACTIONLINT | ||
end |