feat: Add spellr gem for automatic spell-checking #312
Conversation
robotdana
force-pushed
the
dana/add-spellr
branch
3 times, most recently
from
5180e2c to
c14aac2
Compare
the default wordlist may need expanding when doing rails new
robotdana
force-pushed
the
dana/add-spellr
branch
6 times, most recently
from
ee9a012 to
ec211a6
Compare
mischa-s
requested review from
eoinkelly,
G-Rath,
hopkincame,
JacobBriggsAckama,
lukeify and
robramsaynz
There was a problem hiding this comment.
I'm not against this but also am not jumping for joy over it as I'm not sure if it's something we really want to have our CI failing on but it's also possible I'm overthinking it 😅
I won't approve for now because I'm interested in how others feel first, but I do think that the typos you have fixed are something we want so if you can be bothered cherry-picking those into another PR I'd be happy to approve that.
Also does spellr support pulling from a remote source? That could be cool if we do decide to land this, as we could have a wordlist repo that we source common words from rather than having to duplicate the whole list across every project.
| echo "* ******************************************************" | ||
| echo "* Running spellr" | ||
| echo "* ******************************************************" | ||
| bundle exec spellr |
There was a problem hiding this comment.
🐘 I think it's probably better to have this before our heavier checks (probably even as the first check) because I assume its a lot faster and it'd be better to have your CI fail on spelling before rather than after it runs the 20m+ test suite...
|
I share @G-Rath's hesitation about landing this as a CI check but I'm enthusiastic about landing the spelling fixes it found. This might be one we want to live with on a project or two first before we land it here? |
no, but it could: robotdana/spellr#82 |
see https://github.com/robotdana/spellr for some reasons that i find having a spell checker useful
also it seemed like a fitting first pr