feat: support Rails 7.1 #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
support-rails-71
branch
from
b093675 to
70d0052
Compare
G-Rath
force-pushed
the
support-rails-71
branch
from
70d0052 to
348a950
Compare
eoinkelly
reviewed
Oct 21, 2023
| @@ -18,3 +18,7 @@ | |||
| gsub_file "config/environments/development.rb", | |||
| "join('tmp', 'caching-dev.txt')", | |||
| 'join("tmp/caching-dev.txt")' | |||
|
|
|||
| gsub_file "config/environments/development.rb", | |||
There was a problem hiding this comment.
See issue #507 for discussion around this change
|
As of 3 November in our Ruby Guild we have decided that encrypted secrets decision is not a blocker, we only need to decide on |
lukeify
reviewed
Nov 16, 2023
|
|
||
| gsub_file "config/environments/development.rb", | ||
| "config.action_controller.raise_on_missing_callback_actions = true", | ||
| "# config.action_controller.raise_on_missing_callback_actions = true" |
There was a problem hiding this comment.
We are leaving this commented out for now and will land this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #500
This aims to be the minimal changes required for the template to work with Rails 7.1
Things which are not in scope for this PR
TODO
frontend-baseto account for Shakapacker now doing a thing we previously did ourselves.Rack::Handler is deprecated and replaced by Rackup::Handlerwarning. This appears during system tests. It is a knownw Capybara issue which is fixed but waiting on a gem release. Since this is just a warning and will go away in due course, we can ignore it.Setting 'useContentHash' to 'false' in the production environment (specified by NODE_ENV environment variable) is not allowed! Content hashes get added to the filenames regardless of setting useContentHash in 'shakapacker.yml' to false.warning. This warning seems to caused by the defaultshakapacker.yml. Shakapacker generates ashakapacker.ymlfile whereuseContentHash: falseis set in the&defaultsection and thenuseContentHash: trueis explicitly set in the production section. It doesn't seem like a real problem so I think we can ignore this.Rails.application.secretsdeprecation because it will be removed in 7.2. Should we still be generating config/secrets.yml #341 has good context on the last time we discussed this.