fix: return nil
if revision time ends up being zero
#506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String#to_i
works by returning all the digits in a string up to the first non-digit that isn't_
(they're treated as separators) or the end of the string - if no digits are found then zero is returned.One of the feedback items on #461 was that when we can't determine the revision time we should explicitly return
nil
instead of aTime
; but the above logic ofString#to_i
means we can end up returning the start of the epoch which goes against that.This changes our logic so that we explicitly return
nil
if we end up getting a zero, ensuring our "Unknown time" logic will be triggered.