Fix search ISE on sparse relations

src/search/sqlite/database.rs

@@ -128,6 +128,11 @@ impl Database {
 			statement.offset(u64::try_from(offset).context("invalid offset")?);
 		}
 
+		if tracing::enabled!(tracing::Level::TRACE) {
+			let query_string = statement.to_string(SqliteQueryBuilder);
+			tracing::trace!(%query_string, "executing query");
+		}
+
 		let (query, values) = statement.build_rusqlite(SqliteQueryBuilder);
 
 		let connection = self.pool.get().await?;

src/search/sqlite/query.rs

@@ -77,12 +77,11 @@ fn resolve_query(sheet_name: String, node: post::Node) -> Result<SelectStatement
 			Error::MalformedQuery(format!("joined sheet {} not referenced", relation.sheet))
 		})?;
 
-		let mut condition = Expr::col(relation.foreign_key)
-			.equals((base_alias.clone(), KnownColumn::RowId))
-			.into_condition();
+		let mut condition = Condition::all()
+			.add(Expr::col(relation.foreign_key).equals((base_alias.clone(), KnownColumn::RowId)));
 
 		if let Some(relation_condition) = relation.condition {
-			condition = Condition::all().add(condition).add(relation_condition);
+			condition = condition.add(relation_condition)
 		}
 
 		query.left_join(base_reference, condition);

src/search/sqlite/vtable.rs

@@ -242,11 +242,13 @@ unsafe impl vtab::VTabCursor for IronworksTableCursor<'_> {
 
 		let iterator = match index_number {
 			Index::SCAN => Index::Scan(sheet.into_iter()),
-			Index::ROW_ID => match arguments.get::<Option<u32>>(0)? {
+			Index::ROW_ID => match arguments.get::<Option<i32>>(0)? {
 				None => Index::Never,
+				Some(row_id) if row_id < 0 => Index::Never,
 				Some(row_id) => Index::RowId(RowIdIndex {
 					sheet,
-					row_id,
+					row_id: u32::try_from(row_id)
+						.expect("row_id should always be >= 0 due to prior condition"),
 					subrow_id: 0,
 				}),
 			},