Handling Undefined process variable while running vite server #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarashagarwal
temporarily deployed
to
Cloudflare Pages
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
management-ui-dev (Production)
devksingh4
requested changes
Jan 7, 2025
There was a problem hiding this comment.
That fixes it, but seems like a hack we shouldn't be using. Instead, we make sure that the top-level .env file is read in on both the API and the UI side. This file should then define the AWS_REGION since the API needs to know.
My guess as to why this freezes the UI is because the config is in common/ so it tries to compile it live not knowing the AWS_REGION. We could also set the UI's AWS_REGION I guess? or move the config out of common - I thought it would be useful to have them in the same place but maybe not.
tarashagarwal
temporarily deployed
to
Cloudflare Pages
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
management-ui-dev (Production)
tarashagarwal
temporarily deployed
to
Cloudflare Pages
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
management-ui-dev (Production)
devksingh4
temporarily deployed
to
Cloudflare Pages
GitHub Actions
Inactive
github-actions
bot
temporarily deployed
to
management-ui-dev (Production)
devksingh4
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.