Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Blocklist class #28

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Create Blocklist class #28

merged 2 commits into from
Sep 21, 2023

Conversation

boushrabettir
Copy link
Collaborator

@boushrabettir boushrabettir commented Sep 19, 2023 •
edited
Loading

  • A class has been created to manage a list of blacklisted companies. More member functions can be added along the way
  • The member function has been added into both the utility.py and main.py sections to determine whether a given company is or isn't included on the blacklist.

Side Note

  • Updated minimum number of jobs/internships to 13 -> 15

@boushrabettir
Create Blacklist class.
89c7bcc 
- Created simple class for blacklisted companies

- Use BlackList member function in utils and main to determine if the company is NOT a blacklisted company.
@EthanThatOneKid
Copy link
Contributor

Blocklist or disallowlist is preferred over blacklist.

@boushrabettir
Copy link
Collaborator Author

Blocklist or disallowlist is preferred over blacklist. @EthanThatOneKid

Great, I just updated here in this commit.

EthanThatOneKid
EthanThatOneKid approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@EthanThatOneKid EthanThatOneKid changed the title Create Blacklist class Create Blocklist class Sep 21, 2023
@boushrabettir boushrabettir merged commit 9750f50 into main Sep 21, 2023
@boushrabettir boushrabettir deleted the blacklist-01 branch September 21, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EthanThatOneKid EthanThatOneKid EthanThatOneKid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boushrabettir @EthanThatOneKid