Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent season as Discord webhook content #33

Merged
merged 10 commits into from
Sep 30, 2023
Merged

Represent season as Discord webhook content #33

merged 10 commits into from
Sep 30, 2023

Conversation

EthanThatOneKid
Copy link
Contributor

@EthanThatOneKid EthanThatOneKid commented Sep 18, 2023 •
edited
Loading

Resolves #32.

Screenshots

DE91C65F-E46B-4D34-A44F-B925EE0E220C

EthanThatOneKid
EthanThatOneKid commented Sep 18, 2023
View reviewed changes
Copy link
Contributor Author

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve TODO comments.

lib/leaderboard/leaderboard_client.ts Outdated Show resolved Hide resolved
api/dailies.ts Outdated Show resolved Hide resolved
@EthanThatOneKid EthanThatOneKid marked this pull request as ready for review September 30, 2023 03:34
EthanThatOneKid
EthanThatOneKid commented Sep 30, 2023
View reviewed changes
Copy link
Contributor Author

@EthanThatOneKid EthanThatOneKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

karnikaavelumani
karnikaavelumani approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@karnikaavelumani karnikaavelumani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code looks very clean. Thank you for the hard work!

@EthanThatOneKid EthanThatOneKid merged commit e7db981 into main Sep 30, 2023
1 check passed
@EthanThatOneKid EthanThatOneKid deleted the fix/32 branch September 30, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karnikaavelumani karnikaavelumani karnikaavelumani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add top scorers to daily webhook
2 participants
@EthanThatOneKid @karnikaavelumani