Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cart page (2) #141

Merged
merged 37 commits into from
Mar 7, 2024
Merged

Implement cart page (2) #141

merged 37 commits into from
Mar 7, 2024

Conversation

raymosun
Copy link
Contributor

@raymosun raymosun commented Jan 29, 2024

Info

Closes #57. The old branch's linting check got out of sync (possibly because the branch is very old), and the changes are being redone here.

While using the testing API, you can add some items to your cart cookie by navigating to /debug and clicking the 'Fill cart' button.

Changes

  • Creates the Store Cart page at `/store/cart
  • Some imports of UUID were updated to use import type
  • Adds the /debug page, visible when using the testing API, to house debug functionalities like adding items to the cart

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image
image

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 1:59am

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't really gotten a chance to play around with the UI, but here are some code nits I had. Also the transform biggening on the linked event thingy for cart I think we should fix

src/components/store/CartItemCard/index.tsx Outdated Show resolved Hide resolved
src/components/store/CartItemCard/index.tsx Outdated Show resolved Hide resolved
src/components/store/StoreModal/index.tsx Outdated Show resolved Hide resolved
src/lib/types/index.d.ts Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial code quality feedback - i dont know how i would add anything to the cart rn so maybe i'll look at the preview after we merge andy's PR

src/components/common/Modal/index.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Show resolved Hide resolved
src/pages/store/cart.tsx Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/components/store/StoreModal/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgbtm, a bunch of nitpicks below

also, you should pull in changes from main because #94 got merged

src/components/store/StoreConfirmModal/style.module.scss Outdated Show resolved Hide resolved
src/components/store/StoreConfirmModal/index.tsx Outdated Show resolved Hide resolved
src/lib/utils.ts Outdated Show resolved Hide resolved
src/components/store/CartItemCard/index.tsx Show resolved Hide resolved
src/pages/store/cart.tsx Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
src/pages/store/cart.tsx Outdated Show resolved Hide resolved
@raymosun raymosun merged commit bc26967 into main Mar 7, 2024
5 checks passed
@raymosun raymosun deleted the raymond/store-cart-page-ii branch March 7, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Store Cart Page
4 participants