-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cart page (2) #141
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't really gotten a chance to play around with the UI, but here are some code nits I had. Also the transform biggening on the linked event thingy for cart I think we should fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial code quality feedback - i dont know how i would add anything to the cart rn so maybe i'll look at the preview after we merge andy's PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgbtm, a bunch of nitpicks below
also, you should pull in changes from main because #94 got merged
Info
Closes #57. The old branch's linting check got out of sync (possibly because the branch is very old), and the changes are being redone here.
While using the testing API, you can add some items to your cart cookie by navigating to
/debug
and clicking the 'Fill cart' button.Changes
import type
/debug
page, visible when using the testing API, to house debug functionalities like adding items to the cartType of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*
and commented hard to understand areasanywhere else.
Screenshots