Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store item page tweaks + MULTIPLE STORE GALLERY IMAGES #154

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Store item page tweaks + MULTIPLE STORE GALLERY IMAGES #154

merged 13 commits into from
Feb 23, 2024

Conversation

SheepTester
Copy link
Member

Info

Closes #147.

store item page tweaks

and

Multiple store gallery imaegs !!!

Changes

  • transparent store images have background color to separate them from rest of store page
  • multiple store gallery images !!
  • quantity dropdown -> input
    • hidden when max can buy is 1
  • add to button label no longer changes

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image

image

background color:
image

new disable reasons:
image

quantity input hidden when max can buy = 1

image

@vercel Vercel
Copy link

vercel bot commented Feb 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 4:48am

farisashai
farisashai approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks excellent - just one question really

src/components/store/CartOptionsGroup/index.tsx Outdated Show resolved Hide resolved
src/pages/store/item/[uuid].tsx Outdated Show resolved Hide resolved
@SheepTester SheepTester merged commit 9d6afde into main Feb 23, 2024
5 checks passed
@SheepTester SheepTester deleted the sean/store-item-tweaks branch February 23, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farisashai farisashai farisashai approved these changes

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

Assignees

@SheepTester SheepTester

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store Item Page Tweaks
2 participants
@SheepTester @farisashai