This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Adjust status calculations #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuildthecloud
approved these changes
Nov 2, 2023
thedadams
force-pushed
the
status-adjustments
branch
2 times, most recently
from
32f0971 to
16e9e5f
Compare
|
I had to move the |
thedadams
requested review from
njhale,
iwilltry42,
g-linville and
tylerslaton
iwilltry42
approved these changes
Nov 2, 2023
There was an issue where app status was being used to process deployments, jobs, etc but the app status wasn't being persisted. This change should give us the status updates we are looking forward without the "act before persist" issues. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
status-adjustments
branch
from
16e9e5f to
765fcc6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where app status was being used to process deployments, jobs, etc but the app status wasn't being persisted. This change should give us the status updates we are looking forward without the "act before persist" issues.