-
Notifications
You must be signed in to change notification settings - Fork 100
change: allow different protocols on the same port (manager#1566) #2361
Conversation
8a3aad9
to
fd35423
Compare
I feel like this should throw an error/warning way earlier in the process instead of just dropping some ports without further notice. Any opinions on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, requested a logic change and potentially another test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the assumption that @keyallis's feedback is addressed. That's the only thing blocking in my mind here.
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
2d860ce
to
2e98387
Compare
Signed-off-by: Thorsten Klein <[email protected]>
Fixed the logic to match what we discussed before - added related comments. |
Ref https://github.com/acorn-io/manager/issues/1566
With this, it's OK to expose the same port/targetPort combination as long as they're using different protocols (which are non-blocking).
Checklist
This is a title (#1216)
. Here's an example