forked from argoproj/argo-rollouts
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fips v1.6.6 #2
Draft
mugdha-adhav
wants to merge
33
commits into
master
Choose a base branch
from
fips-v1.6.6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fips v1.6.6 #2
+4,390
−715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgoproj#2965) fix: typo fix ("Secrete" -> "Secret") in secret informer Signed-off-by: Bart Smykla <[email protected]>
…ollbackWindow (argoproj#2953) * fix(canary): skip steps when in rollback window and rs is still active Resolve argoproj#2939 Signed-off-by: Andy Chen <[email protected]> * test(canary): add case where rollback when in window and rs is still active Signed-off-by: Andy Chen <[email protected]> * test(replicaset): add test case for IsActive function Signed-off-by: Andy Chen <[email protected]> --------- Signed-off-by: Andy Chen <[email protected]> Co-authored-by: Yohan Belval <[email protected]> Co-authored-by: zachaller <[email protected]>
* fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> * fix: analysis step should be ignored after promote in case if result was inconclusive Signed-off-by: pashakostohrys <[email protected]> --------- Signed-off-by: pashakostohrys <[email protected]>
change file name for readthedoc compat Signed-off-by: zachaller <[email protected]>
* fix: missing notification on error Signed-off-by: zachaller <[email protected]> * fix tests Signed-off-by: zachaller <[email protected]> * aggregate errors Signed-off-by: zachaller <[email protected]> * fix bad stat counts Signed-off-by: zachaller <[email protected]> * return errors Signed-off-by: zachaller <[email protected]> * fix tests on return of errors Signed-off-by: zachaller <[email protected]> * change case on logs Signed-off-by: zachaller <[email protected]> * missed a case Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
…3075) sync notification controller configmaps/secrets first before starting other informers Signed-off-by: zachaller <[email protected]>
…ications (argoproj#3095) * bump notification-engine to fix double send on self server notifications Signed-off-by: zachaller <[email protected]> * codegen Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
* keep rs informer updated Signed-off-by: zachaller <[email protected]> * correct bad log Signed-off-by: zachaller <[email protected]> * add error context Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
* chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> * chores: add missing rollout fields Signed-off-by: ashutosh16 <[email protected]> --------- Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: zachaller <[email protected]>
…j#3064) * fix: prevent hot loop when fully promoted rollout is aborted Signed-off-by: Jesse Suen <[email protected]> * test: change expectations of abort tests Signed-off-by: Jesse Suen <[email protected]> --------- Signed-off-by: Jesse Suen <[email protected]>
…e pods (argoproj#3077) * fix: rollback to stable with dynamicStableScale could go under maxUnavailable Signed-off-by: Jesse Suen <[email protected]> * test: add unit tests Signed-off-by: Jesse Suen <[email protected]> * test: add e2e tests Signed-off-by: Jesse Suen <[email protected]> * refactor: move isReplicaSetReferenced to replicaset.go Signed-off-by: Jesse Suen <[email protected]> --------- Signed-off-by: Jesse Suen <[email protected]>
…oj#3060) fix: inopportune scaling events would result in loss of data Signed-off-by: Jesse Suen <[email protected]>
Signed-off-by: zachaller <[email protected]>
* fix read the docs build Signed-off-by: zachaller <[email protected]> * fix read the docs build Signed-off-by: zachaller <[email protected]> --------- Signed-off-by: zachaller <[email protected]>
* istio destionationrule subsets enforcement Signed-off-by: Dennis Nguyen <[email protected]> * add users Signed-off-by: Dennis Nguyen <[email protected]> * add test case for failure cases Signed-off-by: Dennis Nguyen <[email protected]> --------- Signed-off-by: Dennis Nguyen <[email protected]>
Signed-off-by: zachaller <[email protected]>
Signed-off-by: Justin Marquis <[email protected]> Signed-off-by: zachaller <[email protected]>
…j#3126)" (argoproj#3147) Revert "fix: istio destionationrule subsets enforcement (argoproj#3126)" This reverts commit 04e1119. Signed-off-by: zachaller <[email protected]>
…3200) * fix: for rollouts getting stuck due to bad rs informer updates Signed-off-by: Zach Aller <[email protected]> * fix error msg Signed-off-by: Zach Aller <[email protected]> * change logic Signed-off-by: Zach Aller <[email protected]> * error fmt Signed-off-by: Zach Aller <[email protected]> * change if logic Signed-off-by: Zach Aller <[email protected]> * add test Signed-off-by: Zach Aller <[email protected]> * cleanup test Signed-off-by: Zach Aller <[email protected]> * cleanup test Signed-off-by: Zach Aller <[email protected]> * do not double call Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
Before this change both version 2.29.1 and version 2.29.4 of momentjs were brougth in. The bump from v2.29.1 -> v2.29.4 remediates two CVEs: CVE-2022-24785 [1] and CVE-2022-31129 [2]. The most notable change comes with the bump from v2.29.1 -> v2.29.2 which introduces a breaking change to remediate CVE-2022-24785: Forward slash and backward slash is no longer allowed in locale names. Locales containing either of those characters will not be loaded from the filesystem any longer [3]. Other than that it looks like there's only patch fixes which can be seen in the full changelog [4]. [1] GHSA-8hfj-j24r-96c4 [2] GHSA-wc69-rhjr-hc9g [3] https://gist.github.com/ichernev/1904b564f6679d9aac1ae08ce13bc45c [4] https://github.com/moment/moment/blob/536ad0c348f2f99009755698f491080757a48221/CHANGELOG.md Signed-off-by: Linus Ekman <[email protected]>
* fix: possibly fix conflict on updates to revision Signed-off-by: Zach Aller <[email protected]> * wip Signed-off-by: Zach Aller <[email protected]> * fix one test Signed-off-by: Zach Aller <[email protected]> * fix tests Signed-off-by: Zach Aller <[email protected]> * cleanup Signed-off-by: Zach Aller <[email protected]> * change order Signed-off-by: Zach Aller <[email protected]> * change order to match reality Signed-off-by: Zach Aller <[email protected]> * add comments on exptected actions Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
…rgoproj#3237) Signed-off-by: Zach Aller <[email protected]>
…lout to get stuck (argoproj#3272) * fix: fix the rollout stuck when pod/replicas changed together or canary strategy. Signed-off-by: Liming Liu <[email protected]> * add one unit test case for empty canary service. Signed-off-by: Liming Liu <[email protected]> * use rollout status to get the replicaset hash instead of service Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Liming Liu <[email protected]> Signed-off-by: Zach Aller <[email protected]> Co-authored-by: Liming Liu <[email protected]>
…goproj#3321) * fix: keep rs inormer updated upon updating labels and annotations Signed-off-by: Zach Aller <[email protected]> * give error some context Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
* chore: run codegen in 2024 Signed-off-by: Zach Aller <[email protected]> * chore: remove year from codegen Signed-off-by: Zach Aller <[email protected]> * chore: remove year from codegen Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
fix logging rs name when update fails Signed-off-by: Zach Aller <[email protected]>
* chore: add more logging Signed-off-by: Zach Aller <[email protected]> * chore: remove accidental files Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
…ctor on abort (argoproj#3338) * do not switch service selectors back when using alb due to race between two controllers with pod readiness gates Signed-off-by: Zach Aller <[email protected]> * update tests for alb Signed-off-by: Zach Aller <[email protected]> * lets not check for readiness instead Signed-off-by: Zach Aller <[email protected]> * clean up notes Signed-off-by: Zach Aller <[email protected]> * fix / Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
…rgoproj#3354) fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused fix: stuck rollout when rollout is paused Signed-off-by: ashutosh16 <[email protected]> Co-authored-by: asingh51 <[email protected]>
|
status | URL |
---|---|
CVEs found with status: WARNING | https://cloudbees.ais.acquia.io/devops-pipeline-4-jenkins/blue/organizations/jenkins/KCS-argo-rollouts-PIPELINE/detail/PR-2/4/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.