Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1436: PHP 8.4 compatibility #1834

Merged
merged 4 commits into from
Nov 26, 2024
Merged

CLI-1436: PHP 8.4 compatibility #1834

merged 4 commits into from
Nov 26, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Nov 25, 2024

Motivation

Fixes CLI-1436

Depends on:

Proposed changes

We will follow up to fix the forked dependencies for the packages that seem to be abandoned. I've vetted the code currently in those feature branches but that is not a secure long-term solution.

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run wacli completion

@danepowell danepowell added the bug Something isn't working label Nov 25, 2024
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1834/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1834/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review November 26, 2024 19:25
@danepowell danepowell merged commit 42c689f into acquia:main Nov 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant