Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1436: PHP 8.4 compatibility #97

Merged
merged 1 commit into from
Nov 26, 2024
Merged

CLI-1436: PHP 8.4 compatibility #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/AcquiaDrupalEnvironmentDetector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static function isAhEnv(): bool {
*
* @see https://git.drupalcode.org/project/acsf/blob/8.x-2.62/acsf_init/lib/sites/default/acsf.settings.php#L14
*/
public static function isAcsfEnv(string $ah_group = NULL, string $ah_env = NULL): bool {
public static function isAcsfEnv(?string $ah_group = NULL, ?string $ah_env = NULL): bool {
if (is_null($ah_group)) {
$ah_group = self::getAhGroup();
}
Expand All @@ -54,7 +54,7 @@ public static function isAcsfEnv(string $ah_group = NULL, string $ah_env = NULL)
* @return bool
* TRUE if prod, FALSE otherwise.
*/
public static function isAhProdEnv(string $ah_env = NULL): bool {
public static function isAhProdEnv(?string $ah_env = NULL): bool {
if (is_null($ah_env)) {
$ah_env = self::getAhEnv();
}
Expand All @@ -70,7 +70,7 @@ public static function isAhProdEnv(string $ah_env = NULL): bool {
* @return bool
* TRUE if 'stage', FALSE otherwise.
*/
public static function isAhStageEnv(string $ah_env = NULL): bool {
public static function isAhStageEnv(?string $ah_env = NULL): bool {
if (is_null($ah_env)) {
$ah_env = self::getAhEnv();
}
Expand All @@ -86,7 +86,7 @@ public static function isAhStageEnv(string $ah_env = NULL): bool {
* @return bool
* TRUE if dev, FALSE otherwise.
*/
public static function isAhDevEnv(string $ah_env = NULL): bool {
public static function isAhDevEnv(?string $ah_env = NULL): bool {
if (is_null($ah_env)) {
$ah_env = self::getAhEnv();
}
Expand All @@ -102,7 +102,7 @@ public static function isAhDevEnv(string $ah_env = NULL): bool {
* @return bool
* TRUE if ODE, FALSE otherwise.
*/
public static function isAhOdeEnv(string $ah_env = NULL): bool {
public static function isAhOdeEnv(?string $ah_env = NULL): bool {
if (is_null($ah_env)) {
$ah_env = self::getAhEnv();
}
Expand All @@ -118,7 +118,7 @@ public static function isAhOdeEnv(string $ah_env = NULL): bool {
* @return bool
* TRUE if IDE, FALSE otherwise.
*/
public static function isAhIdeEnv(string $ah_env = NULL): bool {
public static function isAhIdeEnv(?string $ah_env = NULL): bool {
if (is_null($ah_env)) {
$ah_env = self::getAhEnv();
}
Expand Down
Loading