Fix bug in tooltip position calculation

acri-jp · Feb 27, 2020 · df38936 · df38936
1 parent 51fdbd8
commit df38936
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 12 deletions.
diff --git a/build/ableplayer.dist.js b/build/ableplayer.dist.js
@@ -4304,14 +4304,13 @@ var AblePlayerInstances = [];
 						var position = $(this).position();
 						var buttonHeight = $(this).height();
 						var buttonWidth = $(this).width();
-
 						// position() is expressed using top and left (of button);
 						// add right (of button) too, for convenience
 						var controllerWidth = thisObj.$controllerDiv.width();
 						position.right = controllerWidth - position.left - buttonWidth;
-
 						var tooltipY = position.top - buttonHeight - 15;
-						if ($(this).closest('div').hasClass('able-right-controls')) {
+
+						if ($(this).parent().hasClass('able-right-controls')) {
 							// this control is on the right side
               var buttonSide = 'right';
 						}

diff --git a/build/ableplayer.js b/build/ableplayer.js
@@ -4304,14 +4304,13 @@ var AblePlayerInstances = [];
 						var position = $(this).position();
 						var buttonHeight = $(this).height();
 						var buttonWidth = $(this).width();
-
 						// position() is expressed using top and left (of button);
 						// add right (of button) too, for convenience
 						var controllerWidth = thisObj.$controllerDiv.width();
 						position.right = controllerWidth - position.left - buttonWidth;
-
 						var tooltipY = position.top - buttonHeight - 15;
-						if ($(this).closest('div').hasClass('able-right-controls')) {
+
+						if ($(this).parent().hasClass('able-right-controls')) {
 							// this control is on the right side
               var buttonSide = 'right';
 						}

diff --git a/build/ableplayer.min.js b/build/ableplayer.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ableplayer",
-  "version": "4.2.18",
+  "version": "4.2.19",
   "description": "fully accessible HTML5 media player",
   "homepage": "http://ableplayer.github.io/ableplayer",
   "bugs": "https://github.com/ableplayer/ableplayer/issues",

diff --git a/scripts/buildplayer.js b/scripts/buildplayer.js
@@ -1250,14 +1250,13 @@
 						var position = $(this).position();
 						var buttonHeight = $(this).height();
 						var buttonWidth = $(this).width();
-
 						// position() is expressed using top and left (of button);
 						// add right (of button) too, for convenience
 						var controllerWidth = thisObj.$controllerDiv.width();
 						position.right = controllerWidth - position.left - buttonWidth;
-
 						var tooltipY = position.top - buttonHeight - 15;
-						if ($(this).closest('div').hasClass('able-right-controls')) {
+
+						if ($(this).parent().hasClass('able-right-controls')) {
 							// this control is on the right side
               var buttonSide = 'right';
 						}