-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bandit.yml with version bump #2497
base: main
Are you sure you want to change the base?
Conversation
Tagging possible community stakeholders ( i.e. Request for Comment )TL;DR:Regarding which version to pin for
|
eb90bf7
to
212025d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after rebase.
TL;DR - Fixed issue with space when pinning by hash instead of tag. Also rebased with latest version from default branch to ensure compatibility.
Migrate to latest, maintained, version of action. * Maintained action is a fork of the unmaintained previous version. - Versions are still pinnable ( including bug-for-bug compatible `v1.0` ) - Maintained project now utilizes @dependabot to keep sub-dependencies current. - Maintained action is already released on marketplace * Credits both original and maintainer with no change to licensing * Updated to use checkout@v4 already
Two minor changes here: * removed unnecessary whitespace * pined by SHA latest version of python-bandit-scan (v2.1) reactive-firewall@python-bandit-scan@c8b1d56a3964de4e00e7a820dddb38661a4b7566
- removes an un-intended space from the config to fix the syntax. 🙈 Co-authored-by: Josh Soref <[email protected]>
2ac138f
to
c3d6135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💁🏻 LGTM! No conflicts from rebasing (from actions:main
to remain current).
Migrate to latest, maintained, version of bandit code-scanning action.
Noteworthy changes:
v1.0
) - Maintained project now utilizes @dependabot to keep sub-dependencies current.📋 TL;DR - PR Template with checklist from code owners
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.yml
file with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml
). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKEN
so that the workflow runs successfully.For Code Scanning workflows, the workflow:
code-scanning
directory.code-scanning/properties/*.properties.json
file (for example,code-scanning/properties/codeql.properties.json
), with properties set as follows:name
: Name of the Code Scanning integration.creator
: Name of the organization/user producing the Code Scanning integration.PLEASE ADVISE does this need to be changed?
description
: Short description of the Code Scanning integration.categories
: Array of languages supported by the Code Scanning integration.iconName
: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theicons
directory.push
tobranches: [ $default-branch, $protected-branches ]
andpull_request
tobranches: [ $default-branch ]
. We also recommend aschedule
trigger ofcron: $cron-weekly
(for example,codeql.yml
).Some general notes:
actions
organization, or