feat: 新增MySQL规则 #2753
Merged
feat: 新增MySQL规则 #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winfredLIN
reviewed
Nov 22, 2024
winfredLIN
reviewed
Nov 22, 2024
winfredLIN
reviewed
Nov 22, 2024
sqle/driver/mysql/rule/rule.go
Outdated
Comment on lines
5192
to
5193
| if !tableExist || err != nil { | ||
| return err |
There was a problem hiding this comment.
如果table不存在，那error会不等于nil吗？
这是两种情况，都用返回error处理可以吗
There was a problem hiding this comment.
如果表不存在，返回error，会不会导致审核阻塞？
winfredLIN
reviewed
Nov 22, 2024
Comment on lines
+211
to
+215
| func IsOpenEventScheduler(sql string) bool { | ||
| pattern := `(?i)^SET\s+GLOBAL\s+event_scheduler\s*=\s*(ON|1)\s*;` | ||
| reg := regexp.MustCompile(pattern) | ||
| return reg.MatchString(strings.TrimSpace(sql)) | ||
| } |
There was a problem hiding this comment.
除了正则匹配还有其他方法吗？
这个正则无法匹配换行的情况
There was a problem hiding this comment.
暂时没有，目前的语法树解析不支持。这个做法是参照event那个规则做的。
There was a problem hiding this comment.
增加一下单测吧，看看是不是都能匹配
- 单行的
- 换行的
winfredLIN
reviewed
Nov 22, 2024
sqle/driver/mysql/rule/rule.go
Outdated
| @@ -5239,7 +5238,10 @@ func checkTableRowLength(input *RuleHandlerInput) error { | |||
| continue | |||
| } | |||
| // 可能会设置列级别的字符串 | |||
There was a problem hiding this comment.
不理解这个注释的含义
注释+代码，需要能够说明这里为什么这么做，做了什么
winfredLIN
reviewed
Nov 22, 2024
| @@ -5149,3 +5170,191 @@ func checkIndexNameExisted(input *RuleHandlerInput) error { | |||
| func IsIndexConstraint(constraintType ast.ConstraintType) bool { | |||
| return constraintType == ast.ConstraintIndex || constraintType == ast.ConstraintUniqIndex || constraintType == ast.ConstraintKey || constraintType == ast.ConstraintUniqKey | |||
| } | |||
|
|
|||
| func checkTableRowLength(input *RuleHandlerInput) error { | |||
| var rowLengthLimit = input.Rule.Params.GetParam(DefaultSingleParamKeyName).Int() | |||
There was a problem hiding this comment.
若表实际的页长小于人工设置的页长，则该规则失效
winfredLIN
reviewed
Nov 22, 2024
| return charsetNum | ||
| } | ||
|
|
||
| // ComputeOneColumnLength 计算一个列的长度 |
There was a problem hiding this comment.
贴一下长度计算的依据：
- 官方文档
- 用ai使用mysql的风格格式绘制一个表格放在这里
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的 issue
#2732
描述你的变更
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc