Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support provide and get backup strategies based on SQL #2756

Closed
wants to merge 5 commits into from

Conversation

winfredLIN
Copy link
Collaborator

@winfredLIN winfredLIN commented Nov 14, 2024

assign in @ColdWaterLW

关联的 issue

https://github.com/actiontech/sqle-ee/issues/1956
测试1:SQLE会根据不同SQL给出不同的推荐备份策略
https://github.com/actiontech/sqle-ee/issues/1956#issuecomment-2475306294
测试2: 在审核结束后,能够在审核结果中看到SQL推荐的备份策略
https://github.com/actiontech/sqle-ee/issues/1956#issuecomment-2475459932

描述你的变更

在审核时, SQLE会根据不同SQL给出不同的推荐备份策略
目前暂时使用简单的推荐策略:

  • 默认推荐反向SQL
  • 当SQL的影响行数超过1000,则推荐人工备份
  • 当SQL类型是DQL,则推荐无需备份
  • 其他备份方式的推荐在以后的MVP中完成

在审核结束后,能够在审核结果中看到SQL推荐的备份策略

确认项(pr提交后操作)

Tip

请在指定复审人之前,确认并完成以下事项,完成后✅


  • 我已完成自测
  • 我已在关联的issue里补充了实现方案
  • 我已在关联的issue里补充了测试影响面
  • 我已确认了变更的兼容性,如果不兼容则在issue里标记 not_compatible
  • 我已确认了是否要更新文档,如果要更新则在issue里标记 need_update_doc

@winfredLIN winfredLIN requested review from ColdWaterLW and removed request for LordofAvernus November 14, 2024 06:05
@winfredLIN winfredLIN changed the title feat: support provide backup strategies based on SQL during auditing feat: support provide and get backup strategies based on SQL Nov 14, 2024
@winfredLIN winfredLIN closed this Nov 22, 2024
@winfredLIN winfredLIN mentioned this pull request Nov 22, 2024
5 tasks
@winfredLIN winfredLIN deleted the 1956mvp1-2 branch November 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant