Skip to content

Commit

Permalink
Merge pull request #309 from andreynering/chore/remove-exception-supr…
Browse files Browse the repository at this point in the history
…ession

fix: do not suppress errors when loading classes
  • Loading branch information
kbrock authored May 6, 2024
2 parents 30b1799 + 74eeb9d commit 24579e9
Showing 1 changed file with 2 additions and 12 deletions.
14 changes: 2 additions & 12 deletions lib/associations/associations.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ def self.extended(base)
def has_many(association_id, scope = nil, **options, &extension)
if options[:through]
klass_name = association_id.to_s.classify
klass =
begin
klass_name.safe_constantize
rescue StandardError, LoadError
nil
end
klass = klass_name.safe_constantize

if klass && klass < ActiveHash::Base
define_method(association_id) do
Expand All @@ -33,12 +28,7 @@ def has_many(association_id, scope = nil, **options, &extension)

def belongs_to(name, scope = nil, **options)
klass_name = options.key?(:class_name) ? options[:class_name] : name.to_s.camelize
klass =
begin
klass_name.safe_constantize
rescue StandardError, LoadError
nil
end
klass = klass_name.safe_constantize

if klass && klass < ActiveHash::Base
options = { class_name: klass_name }.merge(options)
Expand Down

0 comments on commit 24579e9

Please sign in to comment.