Skip to content

Commit

Permalink
Merge pull request #298 from m-nakamura145/support-ruby-3.3
Browse files Browse the repository at this point in the history
Support Ruby 3.3
  • Loading branch information
flavorjones authored Jan 4, 2024
2 parents 13f1f59 + d3e5865 commit cca9655
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# | 6.1 | | | 2.5 | |
# | 7.0 | | | 2.7 | |
# | 7.1 | | | 2.7 | |
ruby: ['3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile: ['gemfiles/rails_6.1.gemfile', 'gemfiles/rails_7.0.gemfile', 'gemfiles/rails_7.1.gemfile']
include:
- ruby: '2.4'
Expand Down
6 changes: 3 additions & 3 deletions spec/active_hash/base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ class Region < ActiveHash::Base
it "raises a NoMethodError" do
expect {
Country.find_by_name_and_shoe_size("US", 10)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size' (?:for|on) Country/)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size' (?:for|on) (class )?Country/)
end
end
end
Expand Down Expand Up @@ -957,7 +957,7 @@ class Region < ActiveHash::Base
it "raises a NoMethodError" do
expect {
Country.find_by_name_and_shoe_size!("US", 10)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size!' (?:for|on) Country/)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size!' (?:for|on) (class )?Country/)
end
end
end
Expand Down Expand Up @@ -1181,7 +1181,7 @@ class Region < ActiveHash::Base
it "doesn't blow up if you call a missing dynamic finder when fields haven't been set" do
expect do
Country.find_by_name("Foo")
end.to raise_error(NoMethodError, /undefined method `find_by_name' (?:for|on) Country/)
end.to raise_error(NoMethodError, /undefined method `find_by_name' (?:for|on) (class )?Country/)
end
end

Expand Down

0 comments on commit cca9655

Please sign in to comment.