Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.3 #298

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Support Ruby 3.3 #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
# | 6.1 | | | 2.5 | |
# | 7.0 | | | 2.7 | |
# | 7.1 | | | 2.7 | |
ruby: ['3.0', '3.1', '3.2']
ruby: ['3.0', '3.1', '3.2', '3.3']
gemfile: ['gemfiles/rails_6.1.gemfile', 'gemfiles/rails_7.0.gemfile', 'gemfiles/rails_7.1.gemfile']
include:
- ruby: '2.4'
Expand Down
6 changes: 3 additions & 3 deletions spec/active_hash/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ class Region < ActiveHash::Base
it "raises a NoMethodError" do
expect {
Country.find_by_name_and_shoe_size("US", 10)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size' (?:for|on) Country/)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size' (?:for|on) (class )?Country/)
end
end
end
Expand Down Expand Up @@ -957,7 +957,7 @@ class Region < ActiveHash::Base
it "raises a NoMethodError" do
expect {
Country.find_by_name_and_shoe_size!("US", 10)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size!' (?:for|on) Country/)
}.to raise_error(NoMethodError, /undefined method `find_by_name_and_shoe_size!' (?:for|on) (class )?Country/)
end
end
end
Expand Down Expand Up @@ -1181,7 +1181,7 @@ class Region < ActiveHash::Base
it "doesn't blow up if you call a missing dynamic finder when fields haven't been set" do
expect do
Country.find_by_name("Foo")
end.to raise_error(NoMethodError, /undefined method `find_by_name' (?:for|on) Country/)
end.to raise_error(NoMethodError, /undefined method `find_by_name' (?:for|on) (class )?Country/)
end
end

Expand Down