Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not suppress errors when loading classes #309

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: do not suppress errors when loading classes #309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions lib/associations/associations.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@ def self.extended(base)
def has_many(association_id, scope = nil, **options, &extension)
if options[:through]
klass_name = association_id.to_s.classify
klass =
begin
klass_name.safe_constantize
rescue StandardError, LoadError
nil
end
klass = klass_name.safe_constantize

if klass && klass < ActiveHash::Base
define_method(association_id) do
Expand All @@ -33,12 +28,7 @@ def has_many(association_id, scope = nil, **options, &extension)

def belongs_to(name, scope = nil, **options)
klass_name = options.key?(:class_name) ? options[:class_name] : name.to_s.camelize
klass =
begin
klass_name.safe_constantize
rescue StandardError, LoadError
nil
end
klass = klass_name.safe_constantize

if klass && klass < ActiveHash::Base
options = { class_name: klass_name }.merge(options)
Expand Down
Loading