Add column names method

[hatsu38]

This pull request adds the column_names method to the ActiveHash gem.

The column_names method is analogous to the one found in Rails' ActiveRecord, allowing users to retrieve the names of columns defined in an ActiveHash model.

Added column_names method to ActiveHash::Base class.
The method returns an array of string column names, similar to ActiveRecord's column_names method.

Country.column_names
# => ["id", "name", "code"]

close #310

[flavorjones]

@hatsu38 Thank you for submitting this!

If the goal here is to make sure active hash integrates with the CSV gem, can you please add a new spec that verifies this is working as expected? I'd suggest creating a new directory, spec/integration, and a new spec file.

I would also be interested in a short "how to generate CSV" in the README.md file.

[flavorjones]

I would also like to see a short explicit test in spec/active_hash/base_spec.rb like the one I added in #312 for #field_names. Thank you!

[kbrock]

Rails does not have field_names, instead they have column_names. So there is a difference.
Rails explicitly states that column_names is an array of strings.

I'd feel more comfortable with just doing the work for column_names.
@flavorjones what is your take?

def column_names
  field_names.map(&:name)
end

Also looks like field_names << field is not ensuring that a symbol goes in there, but comparison routines assume it is a symbol. I'll create a PR for that.

[flavorjones]

@kbrock I agree, let's not cache column names, and always iterate over field names when it's called. @hatsu38 Can you make that change?

[kbrock]

Now field names are all symbols, so I think we can simplify this:

Suggested change

	field_names.map do |field|
	field.respond_to?(:name) ? field.name : field.to_s.freeze
	end
	fields.map(&:name)

Does that work for you?

[hatsu38]

After merging the latest master, the code worked perfectly! 0306858

[kbrock]

thanks

[kbrock]

@flavorjones Mike, Symbol.name was introduced in ruby 3.0. Do you have an opinion on how to resolve?

I almost think dropping Ruby <3.0 (and therefore rails rails <=6.0. It sounds drastic but they are all EOL since early 2023, and this will work for them, just not the new column_names.

OTOH/ we could use Symbol.to_s and not worry about the frozen world.

[flavorjones]

Oof, hmm. Well for the record: Rails 6.1 is still supported, and it still technically supports Ruby 2.7. Totally annoying.

But: you're right that this is a new feature, and Rails 6.1 is only supported for security updates at this point. So I agree it is feasible and probably preferable to drop support for Ruby < 3.0 in the next minor release.

[kbrock]

w

[kbrock]

@flavorjones do we want to just conditionally do this?

Suggested change

	it "returns an array of column names" do
	expect(Country.column_names).to eq(["name", "iso_name", "size"])
	end
	it "returns an array of column names" do
	skip unless RUBY_VERSION >= "3.0"
	expect(Country.column_names).to eq(["name", "iso_name", "size"])
	end

[flavorjones]

Seems fine to me.

[hatsu38]

I commited! 9679a89

[kbrock]

Hard fought. This looks good.

@flavorjones The githubs humbly requests you take a look at this too.