-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wing bank icon #1211
Open
SyedAzeemAbbas
wants to merge
14
commits into
activemerchant:master
Choose a base branch
from
SyedAzeemAbbas:wing_bank_icon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wing bank icon #1211
SyedAzeemAbbas
wants to merge
14
commits into
activemerchant:master
from
SyedAzeemAbbas:wing_bank_icon
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Lydia-shan-git
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you add a border of #000 with 7% opacity and put your file through SVGO to reduce file size
I have added a border of #000 with 7% opacity and put my file through SVGO to reduce the file size |
Hi Lydia thanks for your response I have gone through your instructions.
Please review and approve my icon at your earliest convenience
…On Thu, Sep 19, 2024 at 12:53 AM Lydia Shan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Make sure you add a border of #000 with 7% opacity and put your file
through SVGO to reduce file size
—
Reply to this email directly, view it on GitHub
<#1211 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACW7JJMHZKJO4F7ROE76XC3ZXHK4LAVCNFSM6AAAAABLYKBUSGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJTGY2DKOBQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*Syed Azeem Abbas*
*+92 3453677361*
|
@Lydia-shan-git Could you please take a look at the updated icon? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you adding this icons?
I'm adding/updating this icon(s) because ..
Help us identify yourself
Link to the brand guidelines:
Checklist to add new icons
db/payment_icons.yml
If this pull request is not adding new icons, you can remove this checklist.
Attach a screenshot of the icon along side the example Visa icon
Tips how to create a screenshot
We have found free online SVG editor https://www.freecodeformat.com/svg-editor.php very useful to create one. Here is a sample code for you to verify that you icon appears properly along side the placeholder.
If the icons are intended for use by Shopify, please provide the following info:
Who are you working with at Shopify? (avoid adding personal details, provide github handle(preferred) or first name and last name)
What's the expected date of this change to deploy on Shopify?