Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Breadpay icon #1248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fkhan-bread
Copy link

Why are you adding this icons?

Updating Bread Pay icon to the most recent branding

Help us identify yourself

  • I'm working/collaborating with the brand directly and they have provided the icons.
  • I'm associated with the brand and I've read all the brand icon’s guidelines.
  • I'm an individual and I've read all the brand icon’s guidelines.

Link to the brand guidelines:

Attach a screenshot of the icon along side the example Visa icon

Screenshot 2024-11-08 at 9 45 43 AM

@fkhan-bread fkhan-bread changed the title ASI-5265 Update Breadpay icon Update Breadpay icon Nov 8, 2024
@dannye0231
Copy link
Contributor

Hi @fkhan-bread , can you check your tags? There is an issue with the SVG:

Failure:
PaymentIconTest#test_Every_payment_SVG_meets_accessibility_requirements [test/unit/payment_icon_test.rb:89]:
{:message=>"The 'g4' ID should be pi-breadpay-g4 (missing 'pi-' prefix)"}.
Expected /pi-(.*)/ to match "g4".

rails test /home/runner/work/payment_icons/payment_icons/test/unit/payment_icon_test.rb:61

.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants