-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sc 74533/trustedform v4 verify language approved #117
Merged
GreenAsGrassAP
merged 7 commits into
master
from
sc-74533/trustedform-v4-verify-language-approved-is
Jul 25, 2024
Merged
Sc 74533/trustedform v4 verify language approved #117
GreenAsGrassAP
merged 7 commits into
master
from
sc-74533/trustedform-v4-verify-language-approved-is
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrayson
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things; let me know if you have questions!
cgrayson
previously approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks!
GreenAsGrassAP
dismissed
cgrayson’s stale review
July 25, 2024 20:56
The merge-base changed after approval.
cgrayson
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
updated v4 integration response to append language approved and ensure it is a boolean value
Type of change
Related tickets
https://app.shortcut.com/active-prospect/story/74533/trustedform-v4-verify-language-approved-is-not-being-appended
Checklists
Development and Testing
Code Review
Tracking
QA