Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc 74533/trustedform v4 verify language approved #117

Merged

Conversation

GreenAsGrassAP
Copy link
Contributor

Description of the change

updated v4 integration response to append language approved and ensure it is a boolean value

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/74533/trustedform-v4-verify-language-approved-is-not-being-appended

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@GreenAsGrassAP GreenAsGrassAP requested a review from cgrayson July 24, 2024 19:02
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things; let me know if you have questions!

CHANGELOG.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
lib/trustedform.js Outdated Show resolved Hide resolved
test/trustedform_spec.js Outdated Show resolved Hide resolved
lib/trustedform.js Outdated Show resolved Hide resolved
@GreenAsGrassAP GreenAsGrassAP requested a review from cgrayson July 25, 2024 17:43
cgrayson
cgrayson previously approved these changes Jul 25, 2024
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks!

@GreenAsGrassAP GreenAsGrassAP dismissed cgrayson’s stale review July 25, 2024 20:56

The merge-base changed after approval.

@GreenAsGrassAP GreenAsGrassAP requested a review from cgrayson July 25, 2024 20:57
@GreenAsGrassAP GreenAsGrassAP merged commit fcfe659 into master Jul 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants