fix test failures

activeprospect · Oct 14, 2024 · 87399fe · 87399fe
1 parent 04e1e8e
commit 87399fe
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/lib/http-error.js b/lib/http-error.js
@@ -11,7 +11,7 @@ class HttpError extends Error {
     this.body = body;
     this.message = 'integration terminated early';
     this.name = 'HttpError';
-    Error.captureStackTrace(this, arguments.callee);
+    Error.captureStackTrace(this);
   }
 }
 

diff --git a/lib/test/types.js b/lib/test/types.js
@@ -1,13 +1,10 @@
-/*
- * DS102: Remove unnecessary code created because of implicit returns
- */
 const types = require('leadconduit-types');
 const flat = require('flat');
 
 module.exports.parser = function(requestVars = []) {
   const typeLookup = {};
 
-  for (let requestVar in requestVars) {
+  for (let requestVar of requestVars) {
     typeLookup[requestVar.name] = types[requestVar.type];
   }
 

diff --git a/test/http-error-spec.js b/test/http-error-spec.js
@@ -18,7 +18,7 @@ describe('HttpError', function() {
     } catch (e) {
       const stack = e.stack.split('\n');
       assert.equal(stack[0], 'HttpError: integration terminated early');
-      return assert.match(stack[1], /at fxn.*test\/http\-error\-spec\.coffee\:/);
+      assert.match(stack[2], /at fxn.*test\/http\-error\-spec\.js\:/);
     }
   });
 

diff --git a/test/util-spec.js b/test/util-spec.js
@@ -60,7 +60,6 @@ describe('Utility functions', function() {
         invokeRequest();
       } catch (error) {
         err = error;
-        console.log(err);
         assert.equal(err.status, 415);
         assert.equal(err.body, 'The GET method is not allowed');
       }