Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decaffeinate and add error handling to parseFullName #28

Merged

Conversation

jgrayson676
Copy link
Contributor

Description of the change

removes all coffeescript and updates the name parsing function to set the full value to first name if an error is caught

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/active-prospect/story/79320/ap-facebook-406-response-from-leadconduit

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

@jgrayson676 jgrayson676 requested a review from cgrayson October 15, 2024 14:12
cgrayson
cgrayson previously approved these changes Oct 15, 2024
Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the comments in lib/http-error.js - either the old commented-out code or the new decaf info - is worth keeping? I didn't get much from those but if you did then that's fine.

Otherwise LGTM, thanks for this!

Copy link
Contributor

@cgrayson cgrayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@jgrayson676 jgrayson676 merged commit 5d6d2ac into master Oct 15, 2024
3 checks passed
@jgrayson676 jgrayson676 deleted the sc-79320/ap-facebook-406-response-from-leadconduit branch October 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants