-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
needed to pass :layout => false to render :action calls in all _respond_... #286
Open
xdotcommer
wants to merge
2,257
commits into
activescaffold:master
Choose a base branch
from
xdotcommer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the use of symbol and string in action_link config
…version methods in controller, like conversion methods for field_search
This reverts commit f8a6288. Conflicts: lib/active_scaffold/extensions/action_controller_rendering.rb
…eprecated in jquery 1.9. - jquery api documentation for the live() method: http://api.jquery.com/live/
Rewrites methods using jquery.live() to use jquery.on() as they are deprecated in jquery 1.9
…nt actions depending on xhr status
…ord_using_RS Fix error with 'Add existing record' using record_select
Fix broken sti links (because of caching)
This reverts commit c1609c3.
…nd_to_js methods to avoid Request Failed 500 errors
:content_type => Mime::JS, :layout => false shouldn't be needed in _respond_to_js methods, format is :js because is called inside a respond_to { |format| format.js } block, so content type should be right. And I never saw layout used in format.js block. Can you post the name of layout which is being used? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to_js methods to avoid Request Failed 500 errors