-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove django model related testing #1065
Conversation
✅ Deploy Preview for activist-org canceled.
|
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
.pre-commit-config.yaml
Outdated
entry: python frontend/i18n/check/run_i18n_checks.py | ||
language: python | ||
stages: [pre-commit] | ||
# - repo: local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note @to-sta that you can disable the checks with git commit --no-verify -m "COMMIT_MESSAGE"
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes here, @to-sta! The frontend checks will end up being problematic for a moment, but the backend ones are fine now :)
Contributor checklist
Description
As discussed in the dev sync, I removed the tests within groups testing, that are django model settings. I also encoutered the i18n_check error again and uncommented the pre-commit check for it, because it prevented me from making this PR.
Related issue