Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove django model related testing #1065

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

to-sta
Copy link
Collaborator

@to-sta to-sta commented Dec 14, 2024

Contributor checklist


Description

As discussed in the dev sync, I removed the tests within groups testing, that are django model settings. I also encoutered the i18n_check error again and uncommented the pre-commit check for it, because it prevented me from making this PR.

Related issue

  • No related issue

Copy link

netlify bot commented Dec 14, 2024

Deploy Preview for activist-org canceled.

Name Link
🔨 Latest commit 1c09bce
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6764b523fa2468000890d353

Copy link
Contributor

github-actions bot commented Dec 14, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

entry: python frontend/i18n/check/run_i18n_checks.py
language: python
stages: [pre-commit]
# - repo: local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note @to-sta that you can disable the checks with git commit --no-verify -m "COMMIT_MESSAGE" :)

@andrewtavis andrewtavis self-requested a review December 14, 2024 19:11
@andrewtavis
Copy link
Member

I'm hoping that c68a358 will fix the i18n checks for you, @to-sta. I figure it was the hard coded Unix style paths :) Let me know if it's still a problem though!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes here, @to-sta! The frontend checks will end up being problematic for a moment, but the backend ones are fine now :)

@andrewtavis andrewtavis merged commit 53ec1c9 into activist-org:main Dec 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants