Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed modal files (#1066) #1068

Merged
merged 10 commits into from
Dec 20, 2024
Merged

Conversation

YoSoyAlexElPine
Copy link
Contributor

Contributor checklist


Description

Files changed:

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 23d3ded
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/6764ba30b87454000815b369
😎 Deploy Preview https://deploy-preview-1068--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@YoSoyAlexElPine
Copy link
Contributor Author

@andrewtavis I need help to fix the prettier format check test. I tried runing with --write but I got more errors.

@andrewtavis andrewtavis self-requested a review December 20, 2024 00:17
@andrewtavis
Copy link
Member

One thing to note here @YoSoyAlexElPine is that the directory above the modal components was still about, which means that given Nuxt they weren't being found/rendered. All good now though :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure what was up with the formatting, @YoSoyAlexElPine, as what you sent looked right, but then my auto save with the version of Prettier that we use did correct them. I'll bring this in regardless of the frontend errors so that the changes can be integrated. Really appreciate you picking this up and also fixing some of the tests that were unrelated! :)

@andrewtavis andrewtavis merged commit cf83551 into activist-org:main Dec 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants