-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed modal files (#1066) #1068
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@andrewtavis I need help to fix the prettier format check test. I tried runing with --write but I got more errors. |
One thing to note here @YoSoyAlexElPine is that the directory above the modal components was still |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really sure what was up with the formatting, @YoSoyAlexElPine, as what you sent looked right, but then my auto save with the version of Prettier that we use did correct them. I'll bring this in regardless of the frontend errors so that the changes can be integrated. Really appreciate you picking this up and also fixing some of the tests that were unrelated! :)
Contributor checklist
Description
Files changed:
ModalEditAboutEvent.vue → ModalEditTextEvent.vue
ModalEditAboutGroup.vue → ModalEditTextGroup.vue
ModalEditAboutOrganization.vue → ModalEditTextOrganization.vue
Rename modal files such as 'ModalEditAbout*.vue' #1066