Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizing Fullscreen, Geolocate, and Navigation controlls #1073

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

Ahm3dGI1
Copy link
Contributor

@Ahm3dGI1 Ahm3dGI1 commented Jan 4, 2025

Contributor checklist


Description

The tooltips and labels for controls FullscreenControl, NavigationControl, and GeolocateControl are now dynamically localized based on the application's current language settings.

Related issue

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 776d895
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/67794344932f7100085a5811
😎 Deploy Preview https://deploy-preview-1073--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)

  • The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo (can be set with git config --global user.email "GITHUB_EMAIL")

@andrewtavis
Copy link
Member

Thanks a lot for the PR, @Ahm3dGI1! Looking at the i18n check, there appears to be a some key issues where the key in the JSON is geolocation, but you're using geolocate. Same for compass and reset_north :) Looks to also be some minor formatting and type check errors in the frontend checks.

Do you want to handle these? Happy to assist as needed 😊

Looking forward to bringing this in!

@Ahm3dGI1
Copy link
Contributor Author

Ahm3dGI1 commented Jan 4, 2025

I fixed the i18n issues. I'm not so sure about the front-end one, tbh. The only idea I have currently is to cast the return of .querySelector() as HTMLElement since its default is to return a general Element | null.

Sorry if I'm taking to much time for this issue but it's my first contribution and the testing is not working on my device for some reason.

@andrewtavis
Copy link
Member

No stress whatsoever, @Ahm3dGI1! I can take a look a little bit later :) Thanks for the fixes you sent along already 😊

Btw, what are the problems you're having with testing right now? Maybe we can help you figure it out or improve the testing setup.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here now, @Ahm3dGI1! So happy to have the i18n of the map at such a high level. Thanks so much for some great work for your first contribution! 🚀 Hope we can work with you again in the future 😊

@andrewtavis andrewtavis merged commit 7847e30 into activist-org:main Jan 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants