-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standardize i18n string references #1119
fix: standardize i18n string references #1119
Conversation
- Replace hardcoded i18n path strings with i18nMap references in components - Update button labels and aria-labels to use i18nMap paths - Remove unnecessary i18nMap imports where direct strings are preferred - Maintain consistent i18n usage pattern across components
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request! ❤️The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
Quick note that we'll need many of these component attributes to be |
And would be amazing if you could get the merge conflicts as well, but let me know if you need some help with those! :) |
I spoke too soon :) Thanks, @aasimsyed! 🚀 |
I'm not sure I understand what you mean here. You want those changes into this PR? |
Yes these changes would need to happen on each component attribute where we're trying to pass the result of the object as a variable. As it's written now in some cases then the string Let me know if it's still confusing! |
- Migrate all static i18n key references to use v-bind syntax (:label/:ariaLabel)
@andrewtavis please review. I think I did what you were asking for. Let me know if there are any other issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more instances needed to get changed, @aasimsyed, and with that I did a few updates for things that weren't quite working after some dependency updates.
Thanks so much for bringing this home, @aasimsyed! Really awesome to have this setup finalized 🚀
CC @OmarAI2003 that the i18nMap
object is now in full use over here. One extra thing I realized for i18n-check
is that we need to give the user the ability for the map file to be written with a license header. I made the changes to add the current way we do it over here into the project, and then we'll just need to add an option for what the license for the project is :)
PS I ran the e2e tests and we're at the ~7 that are already failing, so we're good in those regards as well :) |
Issue: #1100
changes suggested by @andrewtavis
Contributor checklist
Description
Related issue