switch from redis-async to redis-rs

[arniu]

PR Type

Feature

PR Checklist

Check your PR fulfills the following:

• Tests for the changes have been added / updated.
• Documentation comments have been added / updated.
• A changelog entry has been made for the appropriate packages.
• Format code with the latest stable rustfmt

Overview

Roadmap:

• Add redis_cmd!
• Make Command private
• Switch to redis-rs

Resolve #30
Resolve #46

[fakeshadow]

I don't see benefit moving to redis-rs.
redis-async is pretty light and shares all deps with almost any actix-web app.

[arniu]

I don't see benefit moving to redis-rs.
redis-async is pretty light and shares all deps with almost any actix-web app.

Yes, redis-async is much lighter. But it does NOT support SSL or auth.

[fakeshadow]

I don't think that's highly desired feature everyone want and people can implement their own solution for that.

That said I'm not against it for additional feature.

[fakeshadow]

Update:

What this PR claim is not complete true. redis-async's client object could not supporting tls and auth(I did not do a full check on the crate so I could be wrong). But actix-redis does not actually use it's client object. actix-redis start a raw tcp connection with redis server and only use types redis-async offer to pack command and unpack response.

Therefore it would very possible to add tls and authentication support on top of the current code. I'm working on tls feature right now and it connect to my local tls enabled redis-server just fine

[fakeshadow]

Update2:
Auth is already supported by sending command as Command(resp_array!["AUTH", username, password]). So it's not an issue from the beginning.
This command can be called directly from actix-redis though for a fool proof authentication