Skip to content

Commit

Permalink
refactor: remove FPE mask #2284 (marked as #2348) (#3510)
Browse files Browse the repository at this point in the history
marginally related to:
- #2348

closes: #2284

Note:
The removed FPEs were tagged as `#2348` but are related to `#2284`.

I noticed, that the FPE in the `RootTrackStatesWriter` also has the same code but unmasked for the pulls-calculation, but the second code only is for unbiased states, therefore seems not to fire at all.

The FPEs in the `RootTrackSummaryWriter` have the same issue tagged, but seem to be irrelevant by now, so this removes them.

If some future tests fail, it is due to some problematic behaviour that shouldn't occur in the first place. More info could be obtain by disabling the FPE-check.

I couldn't really find, why we masked this one in the git history. Maybe we can try to add some more description to the issue in the future. I will add the findings of this PR to the issue for reference.
  • Loading branch information
AJPfleger authored Aug 16, 2024
1 parent df0ab36 commit 00d84ee
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Examples/Io/Root/src/RootTrackSummaryWriter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,7 @@ ProcessCode RootTrackSummaryWriter::writeT(const AlgorithmContext& ctx,
param[Acts::eBoundTime] - t_time};

for (unsigned int i = 0; i < Acts::eBoundSize; ++i) {
// MARK: fpeMaskBegin(FLTDIV, 1, #2348)
// MARK: fpeMaskBegin(FLTINV, 1, #2348)
pull[i] = res[i] / error[i];
// MARK: fpeMaskEnd(FLTINV)
// MARK: fpeMaskEnd(FLTDIV)
}
}

Expand Down

0 comments on commit 00d84ee

Please sign in to comment.