refactor!: move AMVF and IVF config explicitly (#2509)

Title says it all!

Might be breaking as now `config` must be moved in the parent scope.

It might be better to not move the `config` and pass it as a const reference, not sure though.

Core/include/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp

@@ -169,7 +169,7 @@ class AdaptiveMultiVertexFinder {
   template <
       typename T = InputTrack_t,
       std::enable_if_t<std::is_same<T, BoundTrackParameters>::value, int> = 0>
-  AdaptiveMultiVertexFinder(Config& cfg,
+  AdaptiveMultiVertexFinder(Config cfg,
                             std::unique_ptr<const Logger> logger =
                                 getDefaultLogger("AdaptiveMultiVertexFinder",
                                                  Logging::INFO))
@@ -185,7 +185,7 @@ class AdaptiveMultiVertexFinder {
   /// object
   /// @param logger The logging instance
   AdaptiveMultiVertexFinder(
-      Config& cfg, std::function<BoundTrackParameters(InputTrack_t)> func,
+      Config cfg, std::function<BoundTrackParameters(InputTrack_t)> func,
       std::unique_ptr<const Logger> logger =
           getDefaultLogger("AdaptiveMultiVertexFinder", Logging::INFO))
       : m_cfg(std::move(cfg)),

Core/include/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp

@@ -147,7 +147,7 @@ class AdaptiveMultiVertexFitter {
   template <
       typename T = InputTrack_t,
       std::enable_if_t<std::is_same<T, BoundTrackParameters>::value, int> = 0>
-  AdaptiveMultiVertexFitter(Config& cfg,
+  AdaptiveMultiVertexFitter(Config cfg,
                             std::unique_ptr<const Logger> logger =
                                 getDefaultLogger("AdaptiveMultiVertexFitter",
                                                  Logging::INFO))
@@ -163,7 +163,7 @@ class AdaptiveMultiVertexFitter {
   /// object
   /// @param logger The logging instance
   AdaptiveMultiVertexFitter(
-      Config& cfg, std::function<BoundTrackParameters(InputTrack_t)> func,
+      Config cfg, std::function<BoundTrackParameters(InputTrack_t)> func,
       std::unique_ptr<const Logger> logger =
           getDefaultLogger("AdaptiveMultiVertexFitter", Logging::INFO))
       : m_cfg(std::move(cfg)),

Core/include/Acts/Vertexing/IterativeVertexFinder.hpp

@@ -142,7 +142,7 @@ class IterativeVertexFinder {
   template <
       typename T = InputTrack_t,
       std::enable_if_t<std::is_same<T, BoundTrackParameters>::value, int> = 0>
-  IterativeVertexFinder(Config& cfg,
+  IterativeVertexFinder(Config cfg,
                         std::unique_ptr<const Logger> logger = getDefaultLogger(
                             "IterativeVertexFinder", Logging::INFO))
       : m_cfg(std::move(cfg)),
@@ -156,7 +156,7 @@ class IterativeVertexFinder {
   /// @param func Function extracting BoundTrackParameters from InputTrack_t
   /// object
   /// @param logger The logging instance
-  IterativeVertexFinder(Config& cfg,
+  IterativeVertexFinder(Config cfg,
                         std::function<BoundTrackParameters(InputTrack_t)> func,
                         std::unique_ptr<const Logger> logger = getDefaultLogger(
                             "IterativeVertexFinder", Logging::INFO))

Examples/Algorithms/Vertexing/src/AdaptiveMultiVertexFinderAlgorithm.cpp

@@ -103,7 +103,7 @@ ActsExamples::AdaptiveMultiVertexFinderAlgorithm::executeAfterSeederChoice(
   fitterCfg.annealingTool = annealingUtility;
   fitterCfg.minWeight = 0.001;
   fitterCfg.doSmoothing = true;
-  Fitter fitter(fitterCfg, logger().cloneWithSuffix("AMVFitter"));
+  Fitter fitter(std::move(fitterCfg), logger().cloneWithSuffix("AMVFitter"));
 
   typename Finder::Config finderConfig(std::move(fitter), seedFinder,
                                        ipEstimator, std::move(linearizer),
@@ -113,7 +113,7 @@ ActsExamples::AdaptiveMultiVertexFinderAlgorithm::executeAfterSeederChoice(
   finderConfig.maxIterations = 200;
 
   // Instantiate the finder
-  Finder finder(finderConfig, logger().cloneWithSuffix("AMVFinder"));
+  Finder finder(std::move(finderConfig), logger().cloneWithSuffix("AMVFinder"));
 
   // retrieve input tracks and convert into the expected format
 

Examples/Algorithms/Vertexing/src/IterativeVertexFinderAlgorithm.cpp

@@ -88,7 +88,7 @@ ActsExamples::ProcessCode ActsExamples::IterativeVertexFinderAlgorithm::execute(
                            std::move(seeder), ipEst);
   finderCfg.maxVertices = 200;
   finderCfg.reassignTracksAfterFirstFit = false;
-  Finder finder(finderCfg, logger().cloneWithSuffix("Finder"));
+  Finder finder(std::move(finderCfg), logger().cloneWithSuffix("Finder"));
   Finder::State state(*m_cfg.bField, ctx.magFieldContext);
   Options finderOpts(ctx.geoContext, ctx.magFieldContext);
 

Tests/UnitTests/Core/Vertexing/AdaptiveMultiVertexFinderTests.cpp

@@ -120,7 +120,7 @@ BOOST_AUTO_TEST_CASE(adaptive_multi_vertex_finder_test) {
   Finder::Config finderConfig(std::move(fitter), seedFinder, ipEstimator,
                               std::move(linearizer), bField);
 
-  Finder finder(finderConfig);
+  Finder finder(std::move(finderConfig));
   Finder::State state;
 
   auto csvData = readTracksAndVertexCSV(toolString);
@@ -278,7 +278,7 @@ BOOST_AUTO_TEST_CASE(adaptive_multi_vertex_finder_usertype_test) {
                               std::move(linearizer), bField);
   Finder::State state;
 
-  Finder finder(finderConfig, extractParameters);
+  Finder finder(std::move(finderConfig), extractParameters);
 
   auto csvData = readTracksAndVertexCSV(toolString);
   auto tracks = std::get<TracksData>(csvData);
@@ -421,7 +421,7 @@ BOOST_AUTO_TEST_CASE(adaptive_multi_vertex_finder_grid_seed_finder_test) {
   Finder::Config finderConfig(std::move(fitter), seedFinder, ipEst,
                               std::move(linearizer), bField);
 
-  Finder finder(finderConfig);
+  Finder finder(std::move(finderConfig));
   Finder::State state;
 
   auto csvData = readTracksAndVertexCSV(toolString);
@@ -569,7 +569,7 @@ BOOST_AUTO_TEST_CASE(
   Finder::Config finderConfig(std::move(fitter), seedFinder, ipEst,
                               std::move(linearizer), bField);
 
-  Finder finder(finderConfig);
+  Finder finder(std::move(finderConfig));
   Finder::State state;
 
   auto csvData = readTracksAndVertexCSV(toolString);

Tests/UnitTests/Core/Vertexing/AdaptiveMultiVertexFitterTests.cpp

@@ -124,7 +124,8 @@ BOOST_AUTO_TEST_CASE(adaptive_multi_vertex_fitter_test) {
   // Test smoothing
   fitterCfg.doSmoothing = true;
 
-  AdaptiveMultiVertexFitter<BoundTrackParameters, Linearizer> fitter(fitterCfg);
+  AdaptiveMultiVertexFitter<BoundTrackParameters, Linearizer> fitter(
+      std::move(fitterCfg));
 
   // Create positions of three vertices, two of which (1 and 2) are
   // close to one another and will share a common track later
@@ -378,7 +379,8 @@ BOOST_AUTO_TEST_CASE(adaptive_multi_vertex_fitter_test_athena) {
   // Test smoothing
   // fitterCfg.doSmoothing = true;
 
-  AdaptiveMultiVertexFitter<BoundTrackParameters, Linearizer> fitter(fitterCfg);
+  AdaptiveMultiVertexFitter<BoundTrackParameters, Linearizer> fitter(
+      std::move(fitterCfg));
 
   // Create first vector of tracks
   Vector3 pos1a(0.5_mm, -0.5_mm, 2.4_mm);

Tests/UnitTests/Core/Vertexing/IterativeVertexFinderTests.cpp

@@ -172,7 +172,7 @@ BOOST_AUTO_TEST_CASE(iterative_finder_test) {
 
     cfg.reassignTracksAfterFirstFit = true;
 
-    VertexFinder finder(cfg);
+    VertexFinder finder(std::move(cfg));
     VertexFinder::State state(*bField, magFieldContext);
 
     // Vector to be filled with all tracks in current event
@@ -389,7 +389,7 @@ BOOST_AUTO_TEST_CASE(iterative_finder_test_user_track_type) {
                              ipEstimator);
     cfg.reassignTracksAfterFirstFit = true;
 
-    VertexFinder finder(cfg, extractParameters);
+    VertexFinder finder(std::move(cfg), extractParameters);
     VertexFinder::State state(*bField, magFieldContext);
 
     // Same for user track type tracks
@@ -602,7 +602,7 @@ BOOST_AUTO_TEST_CASE(iterative_finder_test_athena_reference) {
   cfg.maximumChi2cutForSeeding = 49;
   cfg.significanceCutSeeding = 12;
 
-  VertexFinder finder(cfg);
+  VertexFinder finder(std::move(cfg));
   VertexFinder::State state(*bField, magFieldContext);
 
   auto csvData = readTracksAndVertexCSV(toolString);