revert cov inflation, fix kf outputs

acts-project · Dec 19, 2024 · 3e34e7e · 3e34e7e
1 parent 262c153
commit 3e34e7e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 15 deletions.
diff --git a/Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/RefittingAlgorithm.hpp b/Examples/Algorithms/TrackFitting/include/ActsExamples/TrackFitting/RefittingAlgorithm.hpp
@@ -33,8 +33,6 @@ class RefittingAlgorithm final : public IAlgorithm {
     std::shared_ptr<TrackFitterFunction> fit;
     /// Pick a single track for debugging (-1 process all tracks)
     int pickTrack = -1;
-    /// Inflate initial covariance.
-    std::array<double, 6> initialVarInflation = {1., 1., 1., 1., 1., 1.};
   };
 
   /// Constructor of the fitting algorithm

diff --git a/Examples/Algorithms/TrackFitting/src/RefittingAlgorithm.cpp b/Examples/Algorithms/TrackFitting/src/RefittingAlgorithm.cpp
@@ -80,16 +80,10 @@ ActsExamples::ProcessCode ActsExamples::RefittingAlgorithm::execute(
         Acts::PropagatorPlainOptions(ctx.geoContext, ctx.magFieldContext)};
     options.doRefit = true;
 
-    Acts::BoundTrackParameters initialParams(
+    const Acts::BoundTrackParameters initialParams(
         track.referenceSurface().getSharedPtr(), track.parameters(),
         track.covariance(), track.particleHypothesis());
 
-    // Inflate covariance
-    for (auto i = 0ul; i < m_cfg.initialVarInflation.size(); ++i) {
-      initialParams.covariance().value()(i, i) *=
-          m_cfg.initialVarInflation.at(i);
-    }
-
     trackSourceLinks.clear();
     surfSequence.clear();
 

diff --git a/Examples/Python/src/TrackFitting.cpp b/Examples/Python/src/TrackFitting.cpp
@@ -41,7 +41,7 @@ void addTrackFitting(Context& ctx) {
 
   ACTS_PYTHON_DECLARE_ALGORITHM(ActsExamples::RefittingAlgorithm, mex,
                                 "RefittingAlgorithm", inputTracks, outputTracks,
-                                fit, pickTrack, initialVarInflation);
+                                fit, pickTrack);
 
   {
     py::class_<TrackFitterFunction, std::shared_ptr<TrackFitterFunction>>(

diff --git a/Examples/Scripts/Python/truth_tracking_gsf_refitting.py b/Examples/Scripts/Python/truth_tracking_gsf_refitting.py
@@ -44,7 +44,6 @@ def runRefittingGsf(
             acts.logging.INFO,
             inputTracks="kf_tracks",
             outputTracks="gsf_refit_tracks",
-            initialVarInflation=[100.0] * 6,
             fit=acts.examples.makeGsfFitterFunction(
                 trackingGeometry, field, **gsfOptions
             ),

diff --git a/Examples/Scripts/Python/truth_tracking_kalman_refitting.py b/Examples/Scripts/Python/truth_tracking_kalman_refitting.py
@@ -41,7 +41,6 @@ def runRefittingKf(
             level=acts.logging.INFO,
             inputTracks="kf_tracks",
             outputTracks="kf_refit_tracks",
-            initialVarInflation=[100.0] * 6,
             fit=acts.examples.makeKalmanFitterFunction(
                 trackingGeometry, field, **kalmanOptions
             ),
@@ -74,7 +73,7 @@ def runRefittingKf(
     s.addWriter(
         acts.examples.RootTrackSummaryWriter(
             level=acts.logging.INFO,
-            inputTracks="tracks",
+            inputTracks="kf_refit_tracks",
             inputParticles="particles_selected",
             inputTrackParticleMatching="refit_track_particle_matching",
             filePath=str(outputDir / "tracksummary_kf_refit.root"),
@@ -84,9 +83,9 @@ def runRefittingKf(
     s.addWriter(
         acts.examples.TrackFitterPerformanceWriter(
             level=acts.logging.INFO,
-            inputTracks="tracks",
+            inputTracks="kf_refit_tracks",
             inputParticles="particles_selected",
-            inputTrackParticleMatching="track_particle_matching",
+            inputTrackParticleMatching="refit_track_particle_matching",
             filePath=str(outputDir / "performance_kf_refit.root"),
         )
     )