remove cartesian to bound jacobians

acts-project · Dec 19, 2024 · a0d665d · a0d665d
1 parent 217b138
commit a0d665d
Show file tree

Hide file tree

Showing 13 changed files with 0 additions and 80 deletions.
diff --git a/Core/include/Acts/Surfaces/AnnulusBounds.hpp b/Core/include/Acts/Surfaces/AnnulusBounds.hpp
@@ -73,9 +73,6 @@ class AnnulusBounds : public DiscBounds {
   /// @copydoc SurfaceBounds::boundToCartesianJacobian
   SquareMatrix2 boundToCartesianJacobian(const Vector2& lposition) const final;
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final;
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final;
 

diff --git a/Core/include/Acts/Surfaces/ConeBounds.hpp b/Core/include/Acts/Surfaces/ConeBounds.hpp
@@ -82,12 +82,6 @@ class ConeBounds : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;

diff --git a/Core/include/Acts/Surfaces/CylinderBounds.hpp b/Core/include/Acts/Surfaces/CylinderBounds.hpp
@@ -95,12 +95,6 @@ class CylinderBounds : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;

diff --git a/Core/include/Acts/Surfaces/DiscTrapezoidBounds.hpp b/Core/include/Acts/Surfaces/DiscTrapezoidBounds.hpp
@@ -68,9 +68,6 @@ class DiscTrapezoidBounds : public DiscBounds {
   /// @copydoc SurfaceBounds::boundToCartesianJacobian
   SquareMatrix2 boundToCartesianJacobian(const Vector2& lposition) const final;
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final;
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final;
 

diff --git a/Core/include/Acts/Surfaces/InfiniteBounds.hpp b/Core/include/Acts/Surfaces/InfiniteBounds.hpp
@@ -33,12 +33,6 @@ class InfiniteBounds : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;

diff --git a/Core/include/Acts/Surfaces/LineBounds.hpp b/Core/include/Acts/Surfaces/LineBounds.hpp
@@ -52,12 +52,6 @@ class LineBounds : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;

diff --git a/Core/include/Acts/Surfaces/PlanarBounds.hpp b/Core/include/Acts/Surfaces/PlanarBounds.hpp
@@ -45,12 +45,6 @@ class PlanarBounds : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;

diff --git a/Core/include/Acts/Surfaces/RadialBounds.hpp b/Core/include/Acts/Surfaces/RadialBounds.hpp
@@ -64,9 +64,6 @@ class RadialBounds : public DiscBounds {
   /// @copydoc SurfaceBounds::boundToCartesianJacobian
   SquareMatrix2 boundToCartesianJacobian(const Vector2& lposition) const final;
 
-  /// @copydoc SurfaceBounds::cartesianToBoundJacobian
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final;
-
   /// @copydoc SurfaceBounds::boundToCartesianMetric
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final;
 

diff --git a/Core/include/Acts/Surfaces/SurfaceBounds.hpp b/Core/include/Acts/Surfaces/SurfaceBounds.hpp
@@ -64,12 +64,6 @@ class SurfaceBounds {
   virtual SquareMatrix2 boundToCartesianJacobian(
       const Vector2& lposition) const = 0;
 
-  /// Computes the cartesian to bound jacobian at a given local position
-  /// @param lposition is the local position at which the jacobian is computed
-  /// @return the cartesian to bound jacobian
-  virtual SquareMatrix2 cartesianToBoundJacobian(
-      const Vector2& lposition) const = 0;
-
   /// Computes the bound to cartesian metric at a given local position
   /// @param lposition is the local position at which the metric is computed
   /// @return the bound to cartesian metric

diff --git a/Core/src/Surfaces/AnnulusBounds.cpp b/Core/src/Surfaces/AnnulusBounds.cpp
@@ -181,16 +181,6 @@ SquareMatrix2 AnnulusBounds::boundToCartesianJacobian(
   return j;
 }
 
-SquareMatrix2 AnnulusBounds::cartesianToBoundJacobian(
-    const Vector2& lposition) const {
-  SquareMatrix2 j;
-  j(0, 0) = std::cos(lposition[1]);
-  j(0, 1) = std::sin(lposition[1]);
-  j(1, 0) = -std::sin(lposition[1]) / lposition[0];
-  j(1, 1) = std::cos(lposition[1]) / lposition[0];
-  return j;
-}
-
 SquareMatrix2 AnnulusBounds::boundToCartesianMetric(
     const Vector2& lposition) const {
   SquareMatrix2 m;

diff --git a/Core/src/Surfaces/DiscTrapezoidBounds.cpp b/Core/src/Surfaces/DiscTrapezoidBounds.cpp
@@ -61,16 +61,6 @@ SquareMatrix2 DiscTrapezoidBounds::boundToCartesianJacobian(
   return j;
 }
 
-SquareMatrix2 DiscTrapezoidBounds::cartesianToBoundJacobian(
-    const Vector2& lposition) const {
-  SquareMatrix2 j;
-  j(0, 0) = std::cos(lposition[1]);
-  j(0, 1) = std::sin(lposition[1]);
-  j(1, 0) = -std::sin(lposition[1]) / lposition[0];
-  j(1, 1) = std::cos(lposition[1]) / lposition[0];
-  return j;
-}
-
 SquareMatrix2 DiscTrapezoidBounds::boundToCartesianMetric(
     const Vector2& lposition) const {
   SquareMatrix2 m;

diff --git a/Core/src/Surfaces/RadialBounds.cpp b/Core/src/Surfaces/RadialBounds.cpp
@@ -43,16 +43,6 @@ SquareMatrix2 RadialBounds::boundToCartesianJacobian(
   return j;
 }
 
-SquareMatrix2 RadialBounds::cartesianToBoundJacobian(
-    const Vector2& lposition) const {
-  SquareMatrix2 j;
-  j(0, 0) = std::cos(lposition[1]);
-  j(0, 1) = std::sin(lposition[1]);
-  j(1, 0) = -std::sin(lposition[1]) / lposition[0];
-  j(1, 1) = std::cos(lposition[1]) / lposition[0];
-  return j;
-}
-
 SquareMatrix2 RadialBounds::boundToCartesianMetric(
     const Vector2& lposition) const {
   SquareMatrix2 m;

diff --git a/Tests/UnitTests/Core/Surfaces/SurfaceBoundsTests.cpp b/Tests/UnitTests/Core/Surfaces/SurfaceBoundsTests.cpp
@@ -49,11 +49,6 @@ class SurfaceBoundsStub : public SurfaceBounds {
     return SquareMatrix2::Identity();
   }
 
-  SquareMatrix2 cartesianToBoundJacobian(const Vector2& lposition) const final {
-    (void)lposition;
-    return SquareMatrix2::Identity();
-  }
-
   SquareMatrix2 boundToCartesianMetric(const Vector2& lposition) const final {
     (void)lposition;
     return SquareMatrix2::Identity();