fix and docs

acts-project · Dec 19, 2024 · bf236b4 · bf236b4
1 parent 5032c8b
commit bf236b4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 9 deletions.
diff --git a/Core/include/Acts/Surfaces/Surface.hpp b/Core/include/Acts/Surfaces/Surface.hpp
@@ -250,13 +250,19 @@ class Surface : public virtual GeometryObject,
       const BoundaryTolerance& boundaryTolerance = BoundaryTolerance::None(),
       double tolerance = s_onSurfaceTolerance) const;
 
+  /// Calculates the closest point on the boundary of the surface to a given
+  /// point in local coordinates.
+  /// @param lposition The local position to check
+  /// @param metric The metric to use for the calculation
+  /// @return The closest point on the boundary of the surface
   virtual Vector2 closestPointOnBounds(
-      const Vector2& lposition,
-      const std::optional<SquareMatrix2>& metric) const;
+      const Vector2& lposition, std::optional<SquareMatrix2>& metric) const;
 
-  virtual double distanceToBounds(
-      const Vector2& lposition,
-      const std::optional<SquareMatrix2>& metric) const;
+  /// Calculates the distance to the boundary of the surface from a given point
+  /// in local coordinates.
+  /// @param lposition The local position to check
+  /// @return The distance to the boundary of the surface
+  virtual double distanceToBounds(const Vector2& lposition) const;
 
   /// The insideBounds method for local positions
   ///

diff --git a/Core/src/Surfaces/Surface.cpp b/Core/src/Surfaces/Surface.cpp
@@ -252,10 +252,8 @@ Vector2 Surface::closestPointOnBounds(
   return bounds().closestPoint(lposition, metric);
 }
 
-double Surface::distanceToBounds(
-    const Vector2& lposition,
-    const std::optional<SquareMatrix2>& metric) const {
-  return bounds().distance(lposition, metric);
+double Surface::distanceToBounds(const Vector2& lposition) const {
+  return bounds().distance(lposition);
 }
 
 bool Surface::insideBounds(const Vector2& lposition,