-
Notifications
You must be signed in to change notification settings - Fork 174
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Introduce concepts for (Regular)Surface (#2646)
This helps catching missing `using` methods to make derived classes fully comply with the base `Surface` class. C++ inheritance is strange. Blocked by: - #2340
- Loading branch information
1 parent
3d1dc45
commit e574e8a
Showing
8 changed files
with
167 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // This file is part of the Acts project. | ||
| // | ||
| // Copyright (C) 2023 CERN for the benefit of the Acts project | ||
| // | ||
| // This Source Code Form is subject to the terms of the Mozilla Public | ||
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "Acts/Definitions/Algebra.hpp" | ||
| #include "Acts/Definitions/Alignment.hpp" | ||
| #include "Acts/Definitions/TrackParametrization.hpp" | ||
| #include "Acts/Geometry/DetectorElementBase.hpp" | ||
| #include "Acts/Geometry/GeometryContext.hpp" | ||
| #include "Acts/Material/ISurfaceMaterial.hpp" | ||
| #include "Acts/Surfaces/BoundaryCheck.hpp" | ||
| #include "Acts/Surfaces/Surface.hpp" | ||
| #include "Acts/Surfaces/SurfaceBounds.hpp" | ||
| #include "Acts/Utilities/Result.hpp" | ||
|
|
||
| #if defined(__cpp_concepts) | ||
| #include <concepts> | ||
|
|
||
| namespace Acts { | ||
|
|
||
| template <typename S> | ||
| concept SurfaceConcept = requires(S s, const S cs, S s2, const S cs2, | ||
| GeometryContext gctx) { | ||
| { cs == s2 } -> std::same_as<bool>; | ||
|
|
||
| { cs.type() } -> std::same_as<Surface::SurfaceType>; | ||
| { cs.transform(gctx) } -> std::same_as<const Transform3&>; | ||
| { cs.center(gctx) } -> std::same_as<Vector3>; | ||
| { cs.normal(gctx, Vector3{}, Vector3{}) } -> std::same_as<Vector3>; | ||
| { cs.bounds() } -> std::convertible_to<const SurfaceBounds&>; | ||
| { | ||
| cs.associatedDetectorElement() | ||
| } -> std::same_as<const DetectorElementBase*>; | ||
|
|
||
| { cs.associatedLayer() } -> std::same_as<const Layer*>; | ||
| { s.associateLayer(std::declval<const Layer&>()) } -> std::same_as<void>; | ||
|
|
||
| { cs.surfaceMaterial() } -> std::same_as<const ISurfaceMaterial*>; | ||
| { | ||
| cs.surfaceMaterialSharedPtr() | ||
| } -> std::same_as<const std::shared_ptr<const ISurfaceMaterial>&>; | ||
| { | ||
| s.assignSurfaceMaterial( | ||
| std::declval<std::shared_ptr<const ISurfaceMaterial>>()) | ||
| } -> std::same_as<void>; | ||
| { | ||
| cs.isOnSurface(gctx, Vector3{}, Vector3{}, | ||
| std::declval<const BoundaryCheck&>()) | ||
| } -> std::same_as<bool>; | ||
| { | ||
| cs.insideBounds(Vector2{}, std::declval<const BoundaryCheck&>()) | ||
| } -> std::same_as<bool>; | ||
|
|
||
| { cs.localToGlobal(gctx, Vector2{}, Vector3{}) } -> std::same_as<Vector3>; | ||
|
|
||
| { | ||
| cs.globalToLocal(gctx, Vector3{}, Vector3{}, double{5}) | ||
| } -> std::same_as<Result<Vector2>>; | ||
|
|
||
| { | ||
| cs.referenceFrame(gctx, Vector3{}, Vector3{}) | ||
| } -> std::same_as<RotationMatrix3>; | ||
|
|
||
| { | ||
| cs.boundToFreeJacobian(gctx, BoundVector{}) | ||
| } -> std::same_as<BoundToFreeMatrix>; | ||
|
|
||
| { | ||
| cs.boundToFreeJacobian(gctx, BoundVector{}) | ||
| } -> std::same_as<BoundToFreeMatrix>; | ||
|
|
||
| { | ||
| cs.freeToBoundJacobian(gctx, FreeVector{}) | ||
| } -> std::same_as<FreeToBoundMatrix>; | ||
|
|
||
| { | ||
| cs.freeToPathDerivative(gctx, FreeVector{}) | ||
| } -> std::same_as<FreeToPathMatrix>; | ||
|
|
||
| { cs.pathCorrection(gctx, Vector3{}, Vector3{}) } -> std::same_as<double>; | ||
|
|
||
| { | ||
| cs.intersect(gctx, Vector3{}, Vector3{}, | ||
| std::declval<const BoundaryCheck&>(), std::declval<double>()) | ||
| } -> std::same_as<SurfaceMultiIntersection>; | ||
|
|
||
| { | ||
| cs.toStream(gctx, std::declval<std::ostream&>()) | ||
| } -> std::same_as<std::ostream&>; | ||
|
|
||
| { cs.toString(gctx) } -> std::same_as<std::string>; | ||
|
|
||
| { cs.name() } -> std::same_as<std::string>; | ||
|
|
||
| { | ||
| cs.polyhedronRepresentation(gctx, std::declval<std::size_t>()) | ||
| } -> std::same_as<Polyhedron>; | ||
|
|
||
| { | ||
| cs.alignmentToBoundDerivative(gctx, FreeVector{}, FreeVector{}) | ||
| } -> std::same_as<AlignmentToBoundMatrix>; | ||
|
|
||
| { | ||
| cs.alignmentToPathDerivative(gctx, FreeVector{}) | ||
| } -> std::same_as<AlignmentToPathMatrix>; | ||
|
|
||
| { | ||
| cs.localCartesianToBoundLocalDerivative(gctx, Vector3{}) | ||
| } -> std::same_as<ActsMatrix<2, 3>>; | ||
| }; | ||
|
|
||
| template <typename S> | ||
| concept RegularSurfaceConcept = SurfaceConcept<S> && | ||
| requires(S s, const S cs, GeometryContext gctx) { | ||
| { cs.normal(gctx, Vector2{}) } -> std::same_as<Vector3>; | ||
|
|
||
| { cs.normal(gctx, Vector3{}) } -> std::same_as<Vector3>; | ||
|
|
||
| { | ||
| cs.globalToLocal(gctx, Vector3{}, Vector3{}, std::declval<double>()) | ||
| } -> std::same_as<Result<Vector2>>; | ||
|
|
||
| { cs.localToGlobal(gctx, Vector2{}) } -> std::same_as<Vector3>; | ||
| }; | ||
| } // namespace Acts | ||
|
|
||
| #endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters